Support :all as an aggregation mode in DirectFileStore #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sinjo
force-pushed
the
sinjo-unaggregated-gauges
branch
from
9cfb5f1
to
d2ebc02
Compare
dmagliola
reviewed
May 31, 2019
dmagliola
reviewed
May 31, 2019
Sinjo
force-pushed
the
sinjo-unaggregated-gauges
branch
from
cad0a4f
to
4f64dfc
Compare
|
Before I take this out of draft, I'm going to make I think it's cleaner to disallow it completely rather than saying "If you're using the gem in this particular mode then it's okay otherwise we'll overwrite it, sucks to be you!" |
|
Definitely the right call to make it reserved. |
We want to support exporting each process's individual value for gauges. To enable this, DirectFileStore needs a new aggregation mode - :all. Signed-off-by: Chris Sinjakli <chris@gocardless.com>
Sinjo
force-pushed
the
sinjo-unaggregated-gauges
branch
from
f55b61f
to
922a96c
Compare
Signed-off-by: Chris Sinjakli <chris@gocardless.com>
Sinjo
force-pushed
the
sinjo-unaggregated-gauges
branch
from
922a96c
to
b0a49cd
Compare
Signed-off-by: Chris Sinjakli <chris@gocardless.com>
Sinjo
force-pushed
the
sinjo-unaggregated-gauges
branch
from
faa7e89
to
e66ab1b
Compare
|
I've marked this as ready for review. As far as I can tell, the build failures are a (hopefully transient) RVM issue in the JRuby build. Will take a look later if it turns out not to be transient. |
|
Yep, it was transient! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the beginning of the work for #107. I'm going to detail the plan I came up with in there.
Not mega happy with this implementation, so I've marked this PR as a draft for now. Will see if I can come up with anything better.