Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README #130

Merged
merged 1 commit into from
Jun 17, 2019
Merged

Update README #130

merged 1 commit into from
Jun 17, 2019

Conversation

ganmacs
Copy link
Contributor

@ganmacs ganmacs commented Jun 14, 2019

Summary#get returns Hash instance

client_ruby/lib/prometheus/client/summary.rb

Lines 31 to 33 in 3652cf7

internal_counters.each_with_object({}) do |counter, acc|
acc[counter] = @store.get(labels: base_label_set.merge(quantile: counter))
end

Signed-off-by: Yuta Iwama ganmacs@gmail.com

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 34555b7 on ganmacs:update-readme into 3652cf7 on prometheus:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 34555b7 on ganmacs:update-readme into 3652cf7 on prometheus:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 34555b7 on ganmacs:update-readme into 3652cf7 on prometheus:master.

dmagliola
dmagliola approved these changes Jun 14, 2019
View reviewed changes
Copy link
Collaborator

@dmagliola dmagliola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for me. @chris could you confirm this is correct? It sounds correct from memory, but I don't have access to the code.

Thank you for the PR!

@dmagliola
Copy link
Collaborator

Confirmed, that's the correct code.
Sorry for the delay!

@dmagliola dmagliola merged commit 00d093a into prometheus:master Jun 17, 2019
@ganmacs ganmacs deleted the update-readme branch June 18, 2019 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmagliola dmagliola dmagliola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ganmacs @coveralls @dmagliola