-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove concurrent-ruby
dependency
#137
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
We added this dependency to be able to use `ReadWriteLock`, which is a reentract lock. We did not need the Read/Write locking distinction, and at the time, we didn't know that `Monitor` was reentrant, so this seemed to be the best solution. Knowing that `Monitor` is reentrant, we can get rid of the dependency, and simply use `Monitor` instead. Note that we keep `concurrent-ruby` as a *dev* dependency, because the performance benchmarks use other primitives provided by it to synvhronize their threads, but it's not needed for specs to pass, or for production use. Signed-off-by: Daniel Magliola <danielmagliola@gocardless.com>
dmagliola
force-pushed
the
use_monitor_instead_of_read_write_lock
branch
from
June 17, 2019 17:01
83d92f6
to
6401945
Compare
ganmacs
approved these changes
Jun 19, 2019
Sinjo
approved these changes
Jun 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Any chance you could drop the benchmarks in here for posterity?
Sure. TAKE THESE WITH A MASSIVE GRAIN OF SALT, however. As we've learned, benchmarking in my local dev laptop. master (Using
This Branch (using
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added this dependency to be able to use
ReadWriteLock
, which isa reentract lock. We did not need the Read/Write locking distinction,
and at the time, we didn't know that
Monitor
was reentrant, so thisseemed to be the best solution.
Knowing that
Monitor
is reentrant, we can get rid of the dependency,and simply use
Monitor
instead.Note that we keep
concurrent-ruby
as a dev dependency, because theperformance benchmarks use other primitives provided by it to synvhronize
their threads, but it's not needed for specs to pass, or for production use.
As an added bonus, this appears to be measurably faster on multiple thread scenarios.
I only ran a quick benchmark on my laptop, so this is to be taken with a grain of salt,
but at least it doesn't seem to be worse.