Allow use of instance and job labels
#277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These labels were previously reserved under all circumstances, but Prometheus server handles them just fine in the metric data it scrapes. The reason we'd reserved them is that Prometheus automatically generates values for them when it scrapes a target, and we didn't want to cause a collision. It turns out Prometheus handles that collision just fine. By default, Prometheus server will prepend `exported_` to them if they're present in the scraped data (i.e. `exported_instance` and `exported_job`). Users can set `honor_labels` in their Prometheus server config if they prefer the labels from the scraped metric data to take precedence over the labels generated by the server. Signed-off-by: Chris Sinjakli <chris@sinjakli.co.uk>
Sinjo
force-pushed
the
sinjo-loosen-reserved-labels
branch
from
d251b83
to
e53f7ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These labels were previously reserved under all circumstances, but Prometheus server handles them just fine in the metric data it scrapes.
The reason we'd reserved them is that Prometheus automatically generates values for them when it scrapes a target, and we didn't want to cause a collision. It turns out Prometheus handles that collision just fine.
By default, Prometheus server will prepend
exported_to them if they're present in the scraped data (i.e.exported_instanceandexported_job). Users can sethonor_labelsin their Prometheus server config if they prefer the labels from the scraped metric data to take precedence over the labels generated by the server.Signed-off-by: Chris Sinjakli chris@sinjakli.co.uk
Fixes #275