Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client/push: add basic auth #74

Closed
wants to merge 1 commit into from
Closed

client/push: add basic auth #74

wants to merge 1 commit into from

Conversation

josephholsten
Copy link

I should mention that these changes to request make me want to cry. So any alternatives would be much appreciated!

@coveralls
Copy link

coveralls commented Dec 13, 2017 •
edited

Coverage Status

Coverage increased (+0.5%) to 98.453% when pulling 57e3927 on josephholsten:push-auth into 7265125 on prometheus:master.

@coveralls
Copy link

coveralls commented Dec 13, 2017 •
edited

Coverage Status

Coverage increased (+0.5%) to 98.455% when pulling abda5e4 on josephholsten:push-auth into 7265125 on prometheus:master.

@coveralls
Copy link

coveralls commented Dec 13, 2017 •
edited

Coverage Status

Coverage increased (+0.6%) to 98.564% when pulling 306ca03 on josephholsten:push-auth into 7265125 on prometheus:master.

@josephholsten
Copy link
Author

ok, so I just need to build an assertion that the http double received the right kind of net/http request. ugh.

@coveralls
Copy link

coveralls commented Dec 13, 2017 •
edited

Coverage Status

Coverage increased (+0.6%) to 98.564% when pulling 1db8747 on josephholsten:push-auth into 7265125 on prometheus:master.

@9to6
Copy link

9to6 commented Apr 2, 2018

Hello.
Why this PR it not merged yet?
any problems?

@grobie grobie mentioned this pull request May 4, 2018
Closed
@grobie
Copy link
Member

grobie commented May 4, 2018 •
edited

Fixed in 47a6366.

@grobie grobie closed this May 4, 2018
@josephholsten
Copy link
Author

Woo, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@josephholsten @coveralls @9to6 @grobie