Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cargo.toml: Update to Rust edition 2021 #64

Closed
mxinden opened this issue May 23, 2022 · 1 comment
Closed

Cargo.toml: Update to Rust edition 2021 #64

mxinden opened this issue May 23, 2022 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mxinden
Copy link
Member

mxinden commented May 23, 2022

As discussed in #63, we should upgrade to Rust edition 2021.

Tracking this here for the sake of completeness.

//CC @doehyunbaek
@mxinden mxinden added help wanted Extra attention is needed good first issue Good for newcomers labels May 23, 2022
doehyunbaek added a commit to doehyunbaek/client_rust that referenced this issue May 26, 2022
@doehyunbaek
*: Update edition into 2021
2229c7d 
As suggested in prometheus#64,
this commit update edition key of manifest file into 2021.

Before update, I ran 'cargo fix --edition' to check if migration is
needed as this guide(https://doc.rust-lang.org/edition-guide/rust-2021/prelude.html#migration)
says.
There was no change but following message was printed about the
upstream dependencies as mentioned in (https://doc.rust-lang.org/edition-guide/rust-2021/default-cargo-resolver.html#migration)
'When building the following dependencies, the given features will no longer be used:
  syn v1.0.95 (as host dependency) removed features: extra-traits, full, visit, visit-mut

The following differences only apply when building with dev-dependencies:
  standback v0.2.17 (as host dependency) removed features: std
  syn v1.0.95 (as host dependency) removed features: visit'

Signed-off-by: Doehyun Baek <doehyunbaek@gmail.com>
@doehyunbaek doehyunbaek mentioned this issue May 26, 2022
Merged
mxinden pushed a commit that referenced this issue Jun 1, 2022
@doehyunbaek
*/Cargo.toml: Update to 2021 edition (#65)
69e6674 
As suggested in #64,
this commit update edition key of manifest file into 2021.

As documented in 2021 edition guide(https://doc.rust-lang.org/edition-guide/rust-2021/IntoIterator-for-arrays.html),
array.into_iter() now returns owned value instead of references,
This commit changes previous doc comments to utilize new behavior.

Signed-off-by: Doehyun Baek <doehyunbaek@gmail.com>
@mxinden
Copy link
Member Author

mxinden commented Jul 18, 2022

Fixed with #65.

@mxinden mxinden closed this as completed Jul 18, 2022
ackintosh pushed a commit to ackintosh/client_rust that referenced this issue Aug 27, 2022
@doehyunbaek @ackintosh
*/Cargo.toml: Update to 2021 edition (prometheus#65)
0f0f70e 
As suggested in prometheus#64,
this commit update edition key of manifest file into 2021.

As documented in 2021 edition guide(https://doc.rust-lang.org/edition-guide/rust-2021/IntoIterator-for-arrays.html),
array.into_iter() now returns owned value instead of references,
This commit changes previous doc comments to utilize new behavior.

Signed-off-by: Doehyun Baek <doehyunbaek@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mxinden