Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump minimum version to 1.6 and get rid of GO15VENDOREXPERIMENT? #37

Closed
RichiH opened this issue Mar 31, 2016 · 8 comments
Closed

Bump minimum version to 1.6 and get rid of GO15VENDOREXPERIMENT? #37

RichiH opened this issue Mar 31, 2016 · 8 comments

Comments

@RichiH
Copy link
Member

RichiH commented Mar 31, 2016

Subject says it all.
@fabxc
Copy link
Contributor

fabxc commented Mar 31, 2016

There are panics for custom sorts that are not implemented 100% correct.
With all the dependencies one can never be sure.
That's what kept me from it so far.

We could try releasing 0.18.0rc1 compiled with 1.6 and see how it goes.

On Thu, Mar 31, 2016, 10:00 AM Richard Hartmann notifications@github.com
wrote:

Subject says it all.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#37

@RichiH
Copy link
Member Author

RichiH commented Mar 31, 2016

I have been running prometheus and alertmanager compiled with 1.6 since yesterday without any issues; I am honestly surprised that I of all people managed to avoid a possible crash bug :p

Releasing a RC1 sounds like a good approach.

@brian-brazil
Copy link
Contributor

That's not the only issue 1.6 had, I'd wait until 1.6.1 has baked in before upgrading.

@RichiH
Copy link
Member Author

RichiH commented Mar 31, 2016

Is this generally true for all x.y.NULL?

@brian-brazil
Copy link
Contributor

It seems to have been so far for Go anyway. The number of issues does seem to be trending down, so maybe by 1.8 we could not wait for the .1.

@fabxc
Copy link
Contributor

fabxc commented Mar 31, 2016

Yes, we also waited for 1.5.1 back then. I don't feel strongly.

The only feature important to us is the template enhancements. That's not
urgent yet though.

On Thu, Mar 31, 2016, 10:48 AM Brian Brazil notifications@github.com
wrote:

It seems to have been so far for Go anyway. The number of issues does seem
to be trending down, so maybe by 1.8 we could not wait for the .1.

—
You are receiving this because you commented.

Reply to this email directly or view it on GitHub
#37 (comment)

@beorn7
Copy link
Member

beorn7 commented Mar 31, 2016

I've been running prometheus/prometheus compiled with 1.6 pretty heavily for quite some time now in different set ups and haven't run into any issues so far. I think the improved GC behavior is a huge win for heavily loaded Prometheus servers.
I'd vote for doing 0.18.0rc1 with go1.6. But prometheus/prometheus#1493 has to be fixed before that anyway.

@beorn7
Copy link
Member

beorn7 commented Sep 9, 2016

This is not handled via prometheus/common anymore.

@beorn7 beorn7 closed this as completed Sep 9, 2016
gouthamve pushed a commit to gouthamve/common that referenced this issue Jul 22, 2018
Squashed 'tools/' changes from e9e7e6b..b990f48
f459f8c 
b990f48 Merge pull request prometheus#42 from kinvolk/lorenzo/fix-git-diff
224a145 Check if SHA1 exists before calling `git diff`
1c3000d Add auto_apply config for wcloud
0ebf5c0 Fix wcloud -serivice
4fe078a Merge pull request prometheus#39 from weaveworks/fix-wrong-subtree-use
3f4934d Remove generate_latest_map
48beb60 Sync changes done directly in scope/tools
45dcdd5 Merge pull request prometheus#37 from weaveworks/fix-mflag-missing
b895344 Use mflag package from weaveworks fork until we find a better solution
e030008 Merge pull request prometheus#36 from weaveworks/wcloud-service-flags
9cbab40 Add wcloud Makefile
ef55901 Review feedback, and build wcloud in circle.
3fe92f5 Add wcloud deploy --service flag
3527b56 Merge pull request prometheus#34 from weaveworks/repo-branch
92cd0b8 [wcloud] Add support for repo_branch option
9f760ab Allow wcloud users to override username
38037f8 Merge pull request prometheus#33 from weaveworks/wcloud-templates
7acfbd7 Propagate the local username
e6876d1 Add template fields to wcloud config.
f1bb537 Merge pull request prometheus#30 from weaveworks/mike/shell-lint/dont-error-if-empty
e60f5df Merge pull request prometheus#31 from weaveworks/mike/fix-shell-lint-errors
e8e2b69 integrations: Fix a shellcheck linter error
a781575 shell-lint: Don't fail if no shell scripts found
db5efc0 Merge pull request prometheus#28 from weaveworks/mike/add-image-tag
5312c40 Import image-tag script into build tools so it can be shared
7e850f8 Fix logs path
dda9785 Update deploy api
f2f4e5b Fix the wcloud client
3925eb6 Merge pull request prometheus#27 from weaveworks/wcloud-events
77355b9 Lint
d9a1c6c Add wcloud events, update flags and error nicely when there is no config

git-subtree-dir: tools
git-subtree-split: b990f488bdc7909b62d9245bc4b4caf58f5ae7ea
gouthamve pushed a commit to gouthamve/common that referenced this issue Jul 22, 2018
@jml
Make it easy to get a logger with context information (prometheus#37)
de252b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@RichiH @fabxc @beorn7 @brian-brazil