Docs improvements #131
Merged
Docs improvements #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fabxc See the individual commits... |
| @@ -54,7 +52,7 @@ Some examples: | |||
| job:http_inprogress_requests:sum = sum(http_inprogress_requests) by (job) | |||
|
|
|||
| # Drop or rewrite labels in the result time series: | |||
| new_time series{label_to_change="new_value",label_to_drop=""} = old_time series | |||
| new_time_series{label_to_change="new_value",label_to_drop=""} = old_time series | |||
|
👍 otherwise |
juliusv
force-pushed
the
docs-improvements
branch
from
64f1ff5
to
e23dcb6
Compare
| * [Ruby](https://github.com/prometheus/client_ruby) | ||
| * [Python](https://github.com/prometheus/client_python) |
There was a problem hiding this comment.
Is it important to list the client libraries here directly? Having more than one place where something is documented will easily lead to inconsistencies again. What about only linking to the clientlibs page here, so that this kind of problem can't happen again? @juliusv
aylei
pushed a commit
to aylei/docs
that referenced
this pull request
Oct 28, 2019
* Add a new doc for Ansible deployment * Fix the format issue. * Address comments * Update the deployment recommendation (prometheus#128) * Address a comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.