Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ping exporter #1319

Merged
merged 1 commit into from Apr 4, 2019
Merged

add ping exporter #1319

merged 1 commit into from Apr 4, 2019

Conversation

anarcat
Copy link
Contributor

@anarcat anarcat commented Apr 3, 2019

The "ping" exporter is really an "fping" exporter but that's how it is named so I picked that.

@SuperQ
Copy link
Member

SuperQ commented Apr 3, 2019

How does this compare to this one: https://github.com/SuperQ/smokeping_prober

@anarcat
Copy link
Contributor Author

anarcat commented Apr 3, 2019

differences:

  • it's written in Python, not Golang
  • it uses fping instead of a fork of go-ping

similarities:

  • both are not in the current list (and there's no ICMP prober that i can find, except maybe the blackbox exporter, which is not an immediately obvious replacement for new users)

Maybe both should be added?

@anarcat
Copy link
Contributor Author

anarcat commented Apr 3, 2019

darn it, here's another one:

https://github.com/localleon/pingpong

@brian-brazil
Copy link
Contributor

If we're going to add one, it's be https://github.com/SuperQ/smokeping_prober as it's the most in line with the Prometheus way of doing things. We try to list only one exporter for a given purpose, and there's already overlap with the blackbox exporter.

@anarcat
Copy link
Contributor Author

anarcat commented Apr 3, 2019

okay, i rebuild the patch to use the smokeping thing even though i think it's way overkill. :)

i do wonder about the overlap with the blackbox exporter as well.. maybe we should add a note on the blackbox exporter saying it can also do ping instead?

@SuperQ
Copy link
Member

SuperQ commented Apr 4, 2019

Yea, there are a number of Prometheus-compatible probers. The smokeping one I made I call it a prober, rather than exporter, as it's a stand-alone metrics generator rather than something like the blackbox exporter.

You're right, I should add some more description to the smokeping_prober's readme about how it works and why it's similar and different from the blackbox_exporter.

Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 😄

The "ping" exporter is really an "fping" exporter but that's how it is named so I picked that.

Signed-off-by: Antoine Beaupré <anarcat@debian.org>
@brian-brazil
Copy link
Contributor

Thanks!

@anarcat anarcat deleted the patch-1 branch April 4, 2019 16:01
aylei pushed a commit to aylei/docs that referenced this pull request Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants