New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ping exporter #1319
add ping exporter #1319
Conversation
How does this compare to this one: https://github.com/SuperQ/smokeping_prober |
differences:
similarities:
Maybe both should be added? |
darn it, here's another one: |
If we're going to add one, it's be https://github.com/SuperQ/smokeping_prober as it's the most in line with the Prometheus way of doing things. We try to list only one exporter for a given purpose, and there's already overlap with the blackbox exporter. |
okay, i rebuild the patch to use the smokeping thing even though i think it's way overkill. :) i do wonder about the overlap with the blackbox exporter as well.. maybe we should add a note on the blackbox exporter saying it can also do ping instead? |
Yea, there are a number of Prometheus-compatible probers. The smokeping one I made I call it a prober, rather than exporter, as it's a stand-alone metrics generator rather than something like the blackbox exporter. You're right, I should add some more description to the smokeping_prober's readme about how it works and why it's similar and different from the blackbox_exporter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 😄
The "ping" exporter is really an "fping" exporter but that's how it is named so I picked that. Signed-off-by: Antoine Beaupré <anarcat@debian.org>
Thanks! |
The "ping" exporter is really an "fping" exporter but that's how it is named so I picked that.