Use iapetos upstream clojure client #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@grobie This looks like it supersedes the SC one, right? |
|
@brian-brazil yes. The soundcloud one is outdated and from functionality iapetos is more then just a wrapper, like the sound cloud. |
|
If you want to preserve the soundcloud I can keep it but I would suggest to have a note like not maintained actively where iapetos will maintained actively, by clj common org |
|
I'm on vacation right now. Pretty sure no one at soundcloud is
maintaining/using the client anymore, so happy to update our repo to link
to the new one and change the entry here.
…On Thu, Jul 25, 2019, 22:20 Dario Maiocchi ***@***.***> wrote:
https://github.com/clj-commons/meta
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1405?email_source=notifications&email_token=AAAA22BOU5K23JLGMWLT4G3QBIDJZA5CNFSM4IG5SBW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD22VB2Y#issuecomment-515199211>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAA22B5XHSMGJDDOPVZNODQBIDJZANCNFSM4IG5SBWQ>
.
|
|
thank you @grobie enjoy your vacation, I hope isn't that hot like in France :) @brian-brazil we can merge afaik. thx enjoy |
|
I'm in France ;-)
@matthiasr can probably help out as well updating our repo to link to a
better maintained one.
…On Fri, Jul 26, 2019, 09:32 Dario Maiocchi ***@***.***> wrote:
thank you @grobie <https://github.com/grobie> enjoy your vacation, I hope
isn't that hot like in France :)
@brain-brazil we can merge afaik. thx enjoy
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1405?email_source=notifications&email_token=AAAA22FJ6INWMWRGGOL5XCLQBKSADA5CNFSM4IG5SBW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD23YF7A#issuecomment-515343100>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAA22ERMEHEIK22PHZJNQDQBKSADANCNFSM4IG5SBWQ>
.
|
|
Can you add the DCO? |
|
@brian-brazil what do you mean by DCO? never heard before. thx |
Signed-off-by: dmaiocchi <dmaiocchi@suse.com>
MalloZup
force-pushed
the
MalloZup-patch-1
branch
from
3429842
to
644bb40
Compare
|
@brian-brazil DCO added, thx and have nice evening |
|
Thanks! |
aylei
pushed a commit
to aylei/docs
that referenced
this pull request
Oct 28, 2019
* v2.1, v3.0, dev: add a warning in batch operations * Apply suggestions from code review Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com>
eightnoneone
pushed a commit
to eightnoneone/docs
that referenced
this pull request
Apr 20, 2020
Signed-off-by: dmaiocchi <dmaiocchi@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The soundcloud exporter is outdated the community effort of the client is hosted in clj commons, iapetos