Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADOPTERS.md #969

Closed
wants to merge 1 commit into from
Closed

Add ADOPTERS.md #969

wants to merge 1 commit into from

Conversation

RichiH
Copy link
Member

@RichiH RichiH commented Feb 13, 2018

No description provided.

@brian-brazil
Copy link
Contributor

We already have one of these on the front page, and I'd prefer not to have to deal with several hundred PRs of companies adding themselves. A wiki requires no maintenance on our part if you really feel the need to have one of these. Kuberentes doesn't appear to have one.

@grobie
Copy link
Member

grobie commented Feb 13, 2018

I fully agree with @brian-brazil. Requiring a pull request to maintain an incomplete list of some of our thousands of users will create a lot of noise for people subscribed to the repo.

@caniszczyk Can you explain why the CNCF requires such file? What is your expectation how popular projects should deal with the PR noise? Why do you think a wiki page wouldn't work for that use case (I don't understand your comment regarding "grants you permission" in the other PR)? Thanks!

@beorn7
Copy link
Member

beorn7 commented Feb 13, 2018

We effectively have the file already: https://github.com/prometheus/docs/blob/master/content/index.html#L121-L157

Companies have usually been added there by a PR.

@juliusv
Copy link
Member

juliusv commented Feb 13, 2018

@beorn7 The thing with that list is that it only contains companies who have explicitly asked us to put their logos there. It might be problematic for us to add logos without permission ourselves, but it's ok-er for us to add companies that are otherwise public about their Prometheus usage to a simple text file, where a logo is not involved. That would also allow us to list some of the much larger or more well-known companies, such as the New York Times, CERN, BNYMellon, etc.

@brancz
Copy link
Member

brancz commented Feb 13, 2018

I think we can start with a list like that as we don't have more information, but I actually really like the document that etcd has for this, as it highlights the volume of usage and how it's used.

https://github.com/coreos/etcd/blob/master/Documentation/production-users.md

@juliusv
Copy link
Member

juliusv commented Feb 13, 2018

@brancz Nobody is going to keep such a detailed list up to date though...

@beorn7
Copy link
Member

beorn7 commented Feb 13, 2018

I don't see any problem with limiting the list of users to those who explicitly permitted their logo usage. We have by far enough for graduation anyway, and I daresay we are beyond the point where we have to brag about the number of big companies using Prometheus. On the contrary, bragging too much might create the impression we are desperately fishing for attention.

@juliusv
Copy link
Member

juliusv commented Feb 13, 2018

Yeah, not related to graduation at all, but could still help convince some users if they see that several really big/reputable orgs are using it. And coolness factor. Not too much of a brag IMO.

@brancz
Copy link
Member

brancz commented Feb 13, 2018

@juliusv fair point on the maintenance.

@caniszczyk
Copy link
Contributor

Listing adopters/users is a graduation requirement.

Also having an adopter send a PR to list them officially helps guide them through the contribution process too which can be thought of a plus. This may add to the backlog a bit when PRs come in but it's a net positive IMHO. It's up to the team on how this process works.

@juliusv
Copy link
Member

juliusv commented Feb 13, 2018

@caniszczyk The graduation requirements say "(e.g., ADOPTERS.md or logos on the project website).". We already have the logos on the website, so this PR here is just an optional extra.

@caniszczyk
Copy link
Contributor

caniszczyk commented Feb 13, 2018 via email

@juliusv
Copy link
Member

juliusv commented Feb 13, 2018

@caniszczyk Yeah, good idea to add instructions (we currently tell people to open a PR against https://github.com/prometheus/docs/blob/master/content/index.html), but could add a little "Want to see your logo here? ..." blurb.

I'm still for also adding the ADOPTERS.md file of course, which'll make this even easier and not require logo permissions.

@RichiH
Copy link
Member Author

RichiH commented Feb 13, 2018

We're somewhat bikeshedding, but I can see everyone's point.

From a purely practical PoV, having hundreds or thousands of logos in the medium term will make the website load slowly, look fughly, and waste mobile user's data. Also, having one canonical way going forward would make sense.

@caniszczyk Notwithstanding this discussion, the graduation requirements could obviously be improved.

@beorn7
Copy link
Member

beorn7 commented Apr 3, 2019

Is this still relevant?

@brian-brazil
Copy link
Contributor

We've graduated, so I'd say not.

@beorn7
Copy link
Member

beorn7 commented Apr 4, 2019

I'll close it then. @RichiH feel free to re-open if we are mistaken.

@beorn7 beorn7 closed this Apr 4, 2019
aylei pushed a commit to aylei/docs that referenced this pull request Oct 28, 2019
…rometheus#969)

* Added clarification of the meaning and context of the compatible-kill-query option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants