This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
Adding Missing Metrics #132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds compressor bytes in, compressor bytes out, compressor bytes bypassed, and http responses compressed - Adds server selected metrics Signed-off-by: Alex Murphy <amurphy@webstaurantstore.com>
Moumoutaru
force-pushed
the
add-missing-metrics
branch
from
54e04c6
to
39c06f2
Compare
|
Can we get this one completed? I'd also like to add lastsess to the available metrics. |
|
This needs to be rebased. |
|
Also interested to have these metrics added to the exporter. |
SuperQ
added a commit
that referenced
this pull request
May 18, 2019
- Adds compressor bytes in, compressor bytes out, compressor bytes bypassed, and http responses compressed - Adds server selected metrics Rebase of #132 Signed-off-by: Ben Kochie <superq@gmail.com>
|
Hmm, looks like I messed up some of the indenting in the web editor when trying to rebase. |
Merged
|
Closing in favor of #154 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @grobie Any feedback is welcome.
These metrics are exposed via a bosun collector and used on some company Grafana dashboards. Would love to get these added.
Looks like there are a bunch of other missing metrics. I can go ahead and add them as well if desired.
Signed-off-by: Alex Murphy amurphy@webstaurantstore.com