Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

Add missing metrics #154

Merged
merged 2 commits into from May 25, 2019
Merged

Add missing metrics #154

merged 2 commits into from May 25, 2019

Conversation

SuperQ
Copy link
Member

@SuperQ SuperQ commented May 18, 2019

  • Adds compressor bytes in, compressor bytes out, compressor bytes bypassed, and http responses compressed
  • Adds server selected metrics

Rebase of #132

Signed-off-by: Ben Kochie superq@gmail.com

- Adds compressor bytes in, compressor bytes out, compressor bytes bypassed, and http responses compressed
- Adds server selected metrics

Rebase of #132

Signed-off-by: Ben Kochie <superq@gmail.com>
@SuperQ SuperQ requested review from grobie and juliusv May 18, 2019 09:38
Signed-off-by: Ben Kochie <superq@gmail.com>
@juliusv
Copy link
Member

juliusv commented May 18, 2019

Would be good to include all of the new fields in tests somehow?

@SuperQ
Copy link
Member Author

SuperQ commented May 18, 2019

Yea, I was going to look into how those get set up.

@juliusv
Copy link
Member

juliusv commented May 18, 2019

👍 besides that

@SuperQ SuperQ merged commit 1b5c9b8 into master May 25, 2019
@SuperQ SuperQ deleted the superq/more-metrics branch May 25, 2019 16:30
@SuperQ SuperQ mentioned this pull request May 31, 2019
@SuperQ SuperQ mentioned this pull request Jun 17, 2020
grobie added a commit that referenced this pull request Jun 21, 2020
* [CHANGE] Switch logging to go-kit #171
* [CHANGE] Fix metric types #182
* [CHANGE] Fix unit of time metric #183
* [FEATURE] Add filtering on server status #160
* [ENHANCEMENT] Add compression and server selection metrics #154
* [ENHANCEMENT] Add client/server abort metrics #167
* [ENHANCEMENT] Add version info metric (when using UNIX sockets) #180

Note: This release fixes the metric types of counters and renames the following metrics:

* `haproxy_exporter_csv_parse_failures` -> `haproxy_exporter_csv_parse_failures_total`
* `haproxy_exporter_total_scrapes` -> `haproxy_exporter_scrapes_total`
* `haproxy_server_check_duration_milliseconds` -> `haproxy_server_check_duration_seconds`

Signed-off-by: Tobias Schmidt <tobidt@gmail.com>
grobie added a commit that referenced this pull request Jun 21, 2020
* [CHANGE] Switch logging to go-kit #171
* [CHANGE] Fix metric types #182
* [CHANGE] Fix unit of time metric #183
* [FEATURE] Add filtering on server status #160
* [ENHANCEMENT] Add compression and server selection metrics #154
* [ENHANCEMENT] Add client/server abort metrics #167
* [ENHANCEMENT] Add version info metric (when using UNIX sockets) #180

Note: This release fixes the metric types of counters and renames the following metrics:

* `haproxy_exporter_csv_parse_failures` -> `haproxy_exporter_csv_parse_failures_total`
* `haproxy_exporter_total_scrapes` -> `haproxy_exporter_scrapes_total`
* `haproxy_server_check_duration_milliseconds` -> `haproxy_server_check_duration_seconds`

Signed-off-by: Tobias Schmidt <tobidt@gmail.com>

Co-authored-by: Tobias Schmidt <tobidt@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants