This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
Use seconds in haproxy_check_duration_seconds as unit #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to Prometheus best practices, metrics should be using base
units. Times should be exported in seconds, the check duration metric is
the only outlier here.
With this change, all tested metrics adhere to the guidelines:
for file in test/*.metrics; do
promtool check metrics < $file
done
Signed-off-by: Tobias Schmidt <tobidt@gmail.com>
grobie
force-pushed
the
grobie/seconds-unit
branch
from
4d17d2c
to
99ce564
Compare
grobie
added a commit
that referenced
this pull request
Jun 21, 2020
* [CHANGE] Switch logging to go-kit #171 * [CHANGE] Fix metric types #182 * [CHANGE] Fix unit of time metric #183 * [FEATURE] Add filtering on server status #160 * [ENHANCEMENT] Add compression and server selection metrics #154 * [ENHANCEMENT] Add client/server abort metrics #167 * [ENHANCEMENT] Add version info metric (when using UNIX sockets) #180 Note: This release fixes the metric types of counters and renames the following metrics: * `haproxy_exporter_csv_parse_failures` -> `haproxy_exporter_csv_parse_failures_total` * `haproxy_exporter_total_scrapes` -> `haproxy_exporter_scrapes_total` * `haproxy_server_check_duration_milliseconds` -> `haproxy_server_check_duration_seconds` Signed-off-by: Tobias Schmidt <tobidt@gmail.com>
grobie
added a commit
that referenced
this pull request
Jun 21, 2020
* [CHANGE] Switch logging to go-kit #171 * [CHANGE] Fix metric types #182 * [CHANGE] Fix unit of time metric #183 * [FEATURE] Add filtering on server status #160 * [ENHANCEMENT] Add compression and server selection metrics #154 * [ENHANCEMENT] Add client/server abort metrics #167 * [ENHANCEMENT] Add version info metric (when using UNIX sockets) #180 Note: This release fixes the metric types of counters and renames the following metrics: * `haproxy_exporter_csv_parse_failures` -> `haproxy_exporter_csv_parse_failures_total` * `haproxy_exporter_total_scrapes` -> `haproxy_exporter_scrapes_total` * `haproxy_server_check_duration_milliseconds` -> `haproxy_server_check_duration_seconds` Signed-off-by: Tobias Schmidt <tobidt@gmail.com> Co-authored-by: Tobias Schmidt <tobidt@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Prometheus best practices, metrics should be using base
units. Times should be exported in seconds, the check duration metric is
the only outlier here.
With this change, all tested metrics adhere to the guidelines: