Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use NaNs as error values #38

Closed
brian-brazil opened this issue Nov 23, 2018 · 3 comments · Fixed by #53
Closed

Don't use NaNs as error values #38

brian-brazil opened this issue Nov 23, 2018 · 3 comments · Fixed by #53

Comments

@brian-brazil
Copy link

NaNs should only be used in cases where they make mathematical sense. If there's an error you should generally fail the scrape or set up to 0.

See https://stackoverflow.com/questions/53430836/prometheus-sum-one-nan-value-result-into-nan-how-to-avoid-it/
@SuperQ
Copy link
Member

SuperQ commented Apr 14, 2019

/cc @f110

@SuperQ SuperQ mentioned this issue Apr 14, 2019
Closed
@f110
Copy link
Contributor

f110 commented Apr 15, 2019

@SuperQ

Are you working in progress this?
If not, I will create a pull request later.

@SuperQ
Copy link
Member

SuperQ commented Apr 15, 2019

I am not working on it, a PR would be great.

@f110 f110 mentioned this issue Apr 17, 2019
Merged
grobie pushed a commit that referenced this issue Aug 25, 2019
@f110 @grobie
Handle non-existent metrics without NaN values (#53)
4a111e3 
Instead of returning NaN values for metrics which are not supported by older memcached version, this change remove such metrics altogether. For parser errors, memcached_up is set to 0 now.

Fixes #38.

Signed-off-by: Fumihiro Itoh <fmhrit@gmail.com>
@roidelapluie roidelapluie mentioned this issue Feb 14, 2021
Closed
@locmai locmai mentioned this issue Oct 11, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

returns memcached_up = 0 when fail to parse a stats values. f110/memcached_exporter
3 participants
@SuperQ @f110 @brian-brazil