-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
returns memcached_up = 0 when fail to parse a stats values. #53
returns memcached_up = 0 when fail to parse a stats values. #53
Conversation
Signed-off-by: Fumihiro Itoh <fmhrit@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution! I think we should not break the exporter for older memcached versions, so we'll need to find a solution how to handle the situation where a metric doesn't exist at all. See my comment below.
Signed-off-by: Fumihiro Itoh <fmhrit@gmail.com>
Signed-off-by: Fumihiro Itoh <fmhrit@gmail.com>
for old memcached. Signed-off-by: Fumihiro Itoh <fmhrit@gmail.com>
Thank you for your review. I fixed a compatible and some problems. |
@grobie ping |
@grobie Is there anything else to need for merging? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @f110! What do you think about logging key issues only on debug level, to not pollute the logs for old memcached versions?
Signed-off-by: Fumihiro Itoh <fmhrit@gmail.com>
@grobie Thank you for review! You are right! And, There is already to output very noisy log by the previous my PR (#46). So i decided to fix that problem too on this PR. |
Thanks a lot for your contribution @f110. I squashed your commits together for readability and will release a new version shortly. |
Thank you for the merge. |
Version v0.6.0 has been published https://groups.google.com/forum/#!topic/prometheus-announce/INfriYx3o1g Thanks again @f110 and don't worry at all, your comments were easy to read and understand. |
fix #38
If there's an error when parse a stats value, returns
memcached_up = 0
.because other metrics which succeeded in parsing value are useful.
If the LRU crawler does not run, ignoring some keys of related to it.