filesystem: Ignore Docker netns mounts #1047
Conversation
|
From what I've been able to see there's no way to just ignore |
|
Ok, let's do it this way for now. Thanks for the PR! |
|
@daenney We don't read |
|
Aha, that's good to know. Alright, that now begs the question then, should we ignore |
|
Yeah if possible, ignoring nsfs seems better. |
When starting Docker containers a whole bunch of netns (network namespace) mounts are created that the node exporter can't make any sense of (and can't read either). This ignores all nsfs filesystems. Fixes #875 Signed-off-by: Daniele Sluijters <daenney@users.noreply.github.com>
|
Alright, updated to ignore |
|
Is there anything left for me to do on this one? |
collector/filesystem_linux.go
Outdated
| @@ -28,7 +28,7 @@ import ( | |||
|
|
|||
| const ( | |||
| defIgnoredMountPoints = "^/(dev|proc|sys|var/lib/docker/.+)($|/)" | |||
| defIgnoredFSTypes = "^(autofs|binfmt_misc|cgroup|configfs|debugfs|devpts|devtmpfs|fusectl|hugetlbfs|mqueue|overlay|proc|procfs|pstore|rpc_pipefs|securityfs|sysfs|tracefs)$" | |||
| defIgnoredFSTypes = "^(autofs|binfmt_misc|cgroup|configfs|debugfs|devpts|devtmpfs|fusectl|hugetlbfs|mqueue|overlay|proc|procfs|pstore|rpc_pipefs|securityfs|sysfs|tracefs|nsfs)$" | |||
There was a problem hiding this comment.
Please keep the list sorted alphabetically.
When starting Docker containers a whole bunch of netns (network namespace) mounts are created that the node exporter can't make any sense of (and can't read either). This ignores all nsfs filesystems. Fixes prometheus#875 Signed-off-by: Daniele Sluijters <daenney@users.noreply.github.com>
When starting Docker containers a whole bunch of netns (network namespace) mounts are created that the node exporter can't make any sense of (and can't read either).
This ignores the Docker specific mounts under
/run/docker/netns.Fixes #875