Support for CPU, network and filesystem stat collection on NetBSD #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 16, 2020 22:56
Signed-off-by: Staffan Thomen <staffan@thomen.fi>
…qdrops Signed-off-by: Staffan Thomen <staffan@thomen.fi>
Signed-off-by: Staffan Thomen <staffan@thomen.fi>
Signed-off-by: Staffan Thomen <staffan@thomen.fi>
|
Hello, I get some build errors with this PR. I think:
|
|
Yeah I kinda dropped the ball on this PR. Ideally someone with netbsd experience could help getting this into a shape to merge it. E.g fixing these issues, the ci issues and refactor it to get rid of the copypasta |
|
@discordianfish I have a local branch where I have done most of the work so that it applies properly on master. I'll see about submitting it as new pull request(s) and then we can close this. |
|
Thank you for looking into fixing my mess, sorry I can't really help much |
|
I'm going to close this for now. If anyone wants to pick that up, fix the issues and re-submit please do so! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds code to make node_exporter more useful on NetBSD hosts. I mainly cobbled this together from the freebsd and openbsd specific code that was already in here, since I don't speak golang at all.
There probably are opportunities for deduplication--especially netdev_netbsd.go which is a single line difference from the netdev_bsd.go which assumes that a FreeBSD-specific struct member exists--that I just don't know about, and I would ask you to please check my work.
@SuperQ @discordianfish