Use go 1.7 #420
Use go 1.7 #420
Conversation
| @@ -2,7 +2,7 @@ sudo: false | |||
|
|
|||
| language: go | |||
| go: | |||
| - 1.5 | |||
There was a problem hiding this comment.
With Travis, you can actually do 1.x to resolve to the latest point release of Go, so in this case, 1.7.4.
I do it here: https://github.com/mdlayher/wifi/blob/master/.travis.yml#L3
There was a problem hiding this comment.
Ahh, good point, I think we want to use 1.7.x to keep things pinned to a release.
| @@ -2,7 +2,7 @@ machine: | |||
| environment: | |||
| DOCKER_IMAGE_NAME: prom/node-exporter | |||
| QUAY_IMAGE_NAME: quay.io/prometheus/node-exporter | |||
| DOCKER_TEST_IMAGE_NAME: quay.io/prometheus/golang-builder:1.6-base | |||
| DOCKER_TEST_IMAGE_NAME: quay.io/prometheus/golang-builder:1.7-base | |||
There was a problem hiding this comment.
Will this resolve to 1.7.4?
There was a problem hiding this comment.
I'm not sure, will check the circle output.
There was a problem hiding this comment.
@sdurrheimer It looks like the quay image for golang-builder is 1.7.3, I'm not sure what the difference is between -base and -main.
There was a problem hiding this comment.
Came across this too and created prometheus/golang-builder#19 since I couldn't figure it out. Also looks like each variant has their own slightly different copy of the build script etc.
There was a problem hiding this comment.
I updated promu0 to 1.7.4, but we need to update the quay.io packages. I'm not sure how to do that.
There was a problem hiding this comment.
What do you mean by "update the quay.io packages" ?
There was a problem hiding this comment.
I just want to make sure that we get builds from CircleCI to use 1.7.4 for the next release.
Update travis/circle CI builds to use Go 1.7.
| @@ -2,7 +2,7 @@ machine: | |||
| environment: | |||
| DOCKER_IMAGE_NAME: prom/node-exporter | |||
| QUAY_IMAGE_NAME: quay.io/prometheus/node-exporter | |||
| DOCKER_TEST_IMAGE_NAME: quay.io/prometheus/golang-builder:1.6-base | |||
| DOCKER_TEST_IMAGE_NAME: quay.io/prometheus/golang-builder:1.7-base | |||
There was a problem hiding this comment.
Came across this too and created prometheus/golang-builder#19 since I couldn't figure it out. Also looks like each variant has their own slightly different copy of the build script etc.
Update travis/circle CI builds to use Go 1.7.