All counters have _total suffix

[mdlayher]

[zsh|matt@nerr-2]:~/src/github.com/prometheus/node_exporter 0 (counters-total) ± curl -s http://localhost:9101/metrics | promtool check-metrics
http_request_duration_microseconds: use base unit "seconds" instead of "microseconds"

Fixes #558 .

[discordianfish]

I agree that we should do these changes, I'm just not sure yet how to roll them out.

I'd say it's okay to break these now, but I would try to do all foreseeable renaming now instead of breaking things again later.

[SuperQ]

Looks like this needs a rebase.

[discordianfish]

@SuperQ How do you feel about this? Merging and breaking now? I feel like if we do that, we should probably also address all other forseeable changes that break metrics.

[grobie]

Please let's create a proper roadmap first and list all the breaking changes we want to include.

[discordianfish]

@grobie You want to start one?

[grobie]

I don't have any capacity right now to work on node_exporter. At least not before PromCon.

…

On Fri, Jul 7, 2017 at 11:43 AM discordianfish ***@***.***> wrote: @grobie <https://github.com/grobie> You want to start one? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#559 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAANaJNLZLzMdkg4rBVlvHprAUGxpii-ks5sLf3EgaJpZM4M-a3K> .

[brian-brazil]

#150 is the original issue around that, though it didn't go into exact detail. There's also #453.

[SuperQ]

I think we should continue this work to cleanup the node_exporter's metric names, types, etc.

[SuperQ]

Ping, want to rebase this?

[discordianfish]

@SuperQ: What about rebasing+merging this now and make the next release 1.0? I don't feel like doing more 'roadmapping'.

[SuperQ]

Yes, I was thinking the same thing. I want to cleanup more metric names, add types where we can, etc.

[brian-brazil]

We should convert this to seconds while we're at it.

[mdlayher]

Thanks for following up on this, closing this PR.