Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xfs: expose correct fields, fix metric names #708

Merged
merged 1 commit into from
Oct 21, 2017
Merged

xfs: expose correct fields, fix metric names #708

merged 1 commit into from
Oct 21, 2017

Conversation

mdlayher
Copy link
Contributor

I made two mistakes:

  • I was using allocation btree stats as the source for block map btree stats.
  • I named the metrics "block_mapping" instead of "block_map". Too late to fix now? We're not 1.0 so I'd rather just fix it if possible.

@SuperQ
Copy link
Member

SuperQ commented Oct 21, 2017

Yes, please fix naming now. We need to make a big breaking change to fix all the other metric names soon, so now is better. :-)

@mdlayher
Copy link
Contributor Author

Great, want to give LGTM then?

SuperQ
SuperQ approved these changes Oct 21, 2017
View reviewed changes
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdlayher mdlayher merged commit 715ebd1 into master Oct 21, 2017
@mdlayher mdlayher deleted the mdl-fix-xfs branch October 21, 2017 05:24
@SuperQ SuperQ mentioned this pull request Nov 7, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperQ SuperQ SuperQ approved these changes

@grobie grobie Awaiting requested review from grobie

@discordianfish discordianfish Awaiting requested review from discordianfish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdlayher @SuperQ