Escape double quotes in device model family #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperQ
reviewed
Jan 4, 2018
| @@ -73,7 +73,7 @@ parse_smartctl_info() { | |||
| local disk="$1" disk_type="$2" | |||
| while read line ; do | |||
| info_type="$(echo "${line}" | cut -f1 -d: | tr ' ' '_')" | |||
| info_value="$(echo "${line}" | cut -f2- -d: | sed 's/^ \+//g')" | |||
| info_value="$(echo "${line}" | cut -f2- -d: | sed 's/^ \+//g' | sed 's/"/\\"/')" | |||
There was a problem hiding this comment.
This could be simplified to sed 's/^ \+//g ; s/"/\\/'.
But, I also think that this might need a g on the second regexp to match all double quotes in the string.
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some devices has double quotes in it's model family. Something like this:
Model Family: Toshiba 3.5" DT01ACA... Desktop HDDIt makes broken metric:
smartmon_device_info{disk="/dev/sdb",type="sat",model_family="Toshiba 3.5" DT01ACA... Desktop HDD",device_model="TOSHIBA DT01ACA300",serial_number="63QY1WTGS",firmware_version="MX6OABB0"} 1This PR is fixing this by escaping
".