Fix the overflow while parsing ipv6 addr inside net_udp.go #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh good catch! |
discordianfish
approved these changes
Jan 9, 2020
|
Hi @discordianfish, @pgier, @SuperQ can someone please hit the merge button? |
SuperQ
reviewed
Jan 20, 2020
added 3 commits
January 23, 2020 15:56
Example output running the node_exporter using this lib: ``` ERROR: udp_queues collector failed after 0.001350s: couldn't get upd6 queued bytes: cannot parse local_address value in udp socket line: strconv.ParseUint: parsing "000080FE00000000FFADE15609667CFE": value out of range source="collector.go:132" ``` Signed-off-by: Peter Bueschel <peter.bueschel@logmein.com>
Signed-off-by: Peter Bueschel <peter.bueschel@logmein.com>
Signed-off-by: Peter Bueschel <peter.bueschel@logmein.com>
SuperQ
reviewed
Jan 25, 2020
| @@ -1,4 +1,4 @@ | |||
| // Copyright 2019 The Prometheus Authors | |||
| // Copyright 2020 The Prometheus Authors | |||
There was a problem hiding this comment.
@pgier We don't update copyright dates in Prometheus repos. Only the initial date is required. We don't need to revert this, but we should avoid updating these in the future.
There was a problem hiding this comment.
Ah sorry, didn't notice that change when I reviewed this. I agree, make sense not to change these in the future.
peterbueschel
deleted the
peterbueschel/fix-int-overflows-ipv6-addr-parsing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @pgier, Hey @discordianfish, Hey @SuperQ
Currently inside the net_udp.go while parsing the local_addr and remote_addr fields based on ipv6, uint64 is not enough. So, I decided to use []uint8 instead.
Example output running the node_exporter using this lib:
Signed-off-by: Peter Bueschel peter.bueschel@logmein.com