Azure Discovery incorrectly discovering de-allocated VM NICs

[laughtonsm]

Hi

Looks like the Azure Discovery code is using the IP address to determine whether a VM is de-allocated or not. Dynamic Private IP addresses are not released back to the pool when a VM is deallocated. The comment in the code reads

// Unfortunately Azure does not return information on whether a VM is deallocated.
// This information is available via another API call however the Go SDK does not
// yet support this. On deallocated machines, this value happens to be nil so it
// is a cheap and easy way to determine if a machine is allocated or not.

This is no longer the case. It would make more sense now to use the MacAddress property of the NIC, as this will is NULL when the VM is allocated.

[krasi-georgiev]

Thanks for the report.
Do you think you can open a PR for a fix?

[laughtonsm]

Sure…however, I am no Go programmer – quite the opposite. I’ve forked and created PR 4341<#4341> I think this should do it Shaun Laughton Consultant Shaun Laughton Consulting Limited m: +44 7803 836 220 e: shaun@shnlghtn.com<mailto:shaun@shnlghtn.com> w: http://shnlghtn.com<http://shnlghtn.com/> Connect on LinkedIn<https://www.linkedin.com/in/shaun-laughton-95868b4/> | Twitter<https://twitter.com/smlmedlrg> From: Krasi Georgiev <notifications@github.com> Sent: 03 July 2018 15:43 To: prometheus/prometheus <prometheus@noreply.github.com> Cc: Shaun Laughton <shaun@shnlghtn.com>; Author <author@noreply.github.com> Subject: Re: [prometheus/prometheus] Azure Discovery incorrectly discovering de-allocated VM NICs (#4340) Thanks for the report. Do you think you can open a PR for a fix? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#4340 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ARkYWXQW6iWd1gERlpK6h3Bou21mSiqJks5uC4LvgaJpZM4VBCPV>.

[krasi-georgiev]

that might be tricky than as we would probably need a unit tests, DCO signing, changes to the comment etc.

[laughtonsm]

Hi Krasi I’ve amended the commit message with DCO signing message, and pushed my code again. Seems the repo has both the old and new commit messages Shaun Laughton Consultant Shaun Laughton Consulting Limited m: +44 7803 836 220 e: shaun@shnlghtn.com<mailto:shaun@shnlghtn.com> w: http://shnlghtn.com<http://shnlghtn.com/> Connect on LinkedIn<https://www.linkedin.com/in/shaun-laughton-95868b4/> | Twitter<https://twitter.com/smlmedlrg> From: Krasi Georgiev <notifications@github.com> Sent: 03 July 2018 17:16 To: prometheus/prometheus <prometheus@noreply.github.com> Cc: Shaun Laughton <shaun@shnlghtn.com>; Author <author@noreply.github.com> Subject: Re: [prometheus/prometheus] Azure Discovery incorrectly discovering de-allocated VM NICs (#4340) that might be tricky than as we would probably need a unit tests, DCO signing, changes to the comment etc. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#4340 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ARkYWUQ2dO7hFsBI8UivkjMdKDzvAP_zks5uC5i3gaJpZM4VBCPV>.

[dmitsh]

I'm looking into this.

[brian-brazil]

Looking at this for our bugscrub, business logic like this belongs in relabelling. #5569 aims to add the metadata that'd allow for this.

[krajorama]

Hello from the bug scrub. Keeping this open as active.