Azure SD: Update predicate check if VM is active #13581
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: darshanime <deathbullet@gmail.com>
darshanime
changed the title
darshanime
changed the title
|
@roidelapluie do you remember who can do PR reviews for Azure SD? Sorry @darshanime that it is so hard to find a reviewer for this. |
|
It is wrong to not include powered off VMS. If a VM is powered off , you want to know that up == 0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per Azure/azure-sdk-for-go#2838, we can use the
InstanceViewStatusto view the power status. This was attempted in #4908, but was later reverted due to nil deference.Also updated the current logic to check
MacAddress == nilas discussed in #4340related to #5569
closes #4340