-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azure service discovery does not report public IP #5588
Comments
The label for public IP is not added because azure SDK does not populate I've opened an issue Azure/azure-sdk-for-go#4829 for Azure SDK team. |
is this not fixed with #5475 ? |
@dmitsh |
@silencev you may want to take a look at https://github.com/dmitsh/prometheus/blob/ds-up-azure-discovery-wip/discovery/azure/azure.go#L504 |
I'm using relabel for workaround now.
|
Please send us a PR with this feature, but if this lookup causes another RPC call to the API, we'd likely not add it because the Azure API limits are very low already and adding additional RPCs will make things worse. |
Fixes prometheus#5588, prometheus#9293 Signed-off-by: Gavin Lam <gavin.oss@tutamail.com>
Hi, I worked on a fix and created a PR #13241. Please help to review the changes. |
…s#13241) Fixes prometheus#5588, prometheus#9293 Signed-off-by: Gavin Lam <gavin.oss@tutamail.com>
Bug Report
What did you do?
Run azure service discovery
What did you expect to see?
A label with VM's public IP should be added to the target VMs
What did you see instead? Under which circumstances?
The label with public IP was missing
Environment
System information:
Linux 4.15.0-50-generic x86_64
Prometheus version:
prometheus, version 2.9.2 (branch: upstream-master, revision: d6a4daa)
go version: go1.12.4
Prometheus configuration file:
The text was updated successfully, but these errors were encountered: