add limit to the rules api #10152
add limit to the rules api #10152
Conversation
|
Closing and re-opening to trigger CI. |
There was a problem hiding this comment.
Almost there! Thanks for making those changes, and DCO looks good this time. Presuming the tests pass, which I think they will, there's only one more thing: the limit field should be added to the sample API response right below the interval field.
prometheus/docs/querying/api.md
Line 622 in 129ed4e
|
I have added that too do let me know for tasks that needed to be completed before this release would like to learn and contribute more to this project |
Signed-off-by: alphasaurs <alphasaurs@gmail.com>
Signed-off-by: alphasaurs <alphasaurs@gmail.com>
This reverts commit d973bb25585d13204d1a6e34f828504ac9359d71. Signed-off-by: alphasaurs <alphasaurs@gmail.com>
Signed-off-by: alphasaurs <alphasaurs@gmail.com>
docs/querying/api.md
Outdated
| @@ -620,6 +620,7 @@ $ curl http://localhost:9090/api/v1/rules | |||
| ], | |||
| "file": "/rules.yaml", | |||
| "interval": 60, | |||
| "limit": 0, | |||
There was a problem hiding this comment.
nit: no extra spacing is needed here.
| "limit": 0, | |
| "limit": 0, |
As the release will be cut tomorrow, I don't think there's anything left to get it, but you can certainly contribute to future releases. Nothing specific comes to mind right now, but you can always find more tasks in the issue tracker. I'm so glad for your enthusiasm in the project! |
Signed-off-by: alphasaurs <alphasaurs@gmail.com>
Signed-off-by: suyashtava <suyashtava@gmail.com>
Trying to add limit and close this issue #9342
thanks @LeviHarrison for review I have incorporated your comments in this pr
please do let me know for other changes if any.
Signed-off-by: alphasaurs alphasaurs@gmail.com