Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cut v2.33-rc.0 #10156

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Cut v2.33-rc.0 #10156

merged 1 commit into from
Jan 13, 2022

Conversation

beorn7
Copy link
Member

@beorn7 beorn7 commented Jan 12, 2022

🚀

@beorn7 beorn7 changed the title Cut v2.33 Cut v2.33-rc.0 Jan 12, 2022
@LeviHarrison
Copy link
Member

#10152 was last minute but added the limit field to the rules API.

@beorn7
Copy link
Member Author

beorn7 commented Jan 12, 2022

#10152 was last minute but added the limit field to the rules API.

That's already in the changelog. Did you miss it, or did I misdescribe the change?

@LeviHarrison
Copy link
Member

Ah, I forget we called the API "Web", but it is slightly misdescribed.

LeviHarrison
LeviHarrison reviewed Jan 12, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@beorn7
Copy link
Member Author

beorn7 commented Jan 12, 2022

Yeah, having the API under "web" is a bit weird, but we have done so before, and it's the name of the directory this is in…

Thanks for your suggestion. I'll update the PR momentarily.

LeviHarrison
LeviHarrison reviewed Jan 12, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Nexucis
Nexucis reviewed Jan 12, 2022
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@beorn7
Cut v2.33-rc.0
c19e75f 
Signed-off-by: beorn7 <beorn@grafana.com>
@beorn7
Copy link
Member Author

beorn7 commented Jan 13, 2022

All comments addressed. Please have another look.

roidelapluie
roidelapluie approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@roidelapluie roidelapluie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

Nexucis
Nexucis approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@Nexucis Nexucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@beorn7
Copy link
Member Author

beorn7 commented Jan 13, 2022

Thanks everyone. 🚢

@beorn7 beorn7 merged commit de51e98 into release-2.33 Jan 13, 2022
@beorn7 beorn7 deleted the beorn7/release branch January 13, 2022 14:23
@beorn7
Copy link
Member Author

beorn7 commented Jan 13, 2022

/prombench v2.32.1

@prombot
Copy link
Contributor

prombot commented Jan 13, 2022

⏱️ Welcome to Prometheus Benchmarking Tool. ⏱️

Compared versions: PR-10156 and v2.32.1

After successful deployment, the benchmarking metrics can be viewed at:

Other Commands:
To stop benchmark: /prombench cancel
To restart benchmark: /prombench restart v2.32.1

@prombot
Copy link
Contributor

prombot commented Jan 16, 2022

Benchmark tests are running for 3 days! If this is intended ignore this message otherwise you can cancel it by commenting: /prombench cancel

@beorn7
Copy link
Member Author

beorn7 commented Jan 17, 2022

/prombench cancel

I couldn't spot any substantial differences.

@prombot
Copy link
Contributor

prombot commented Jan 17, 2022

Benchmark cancel is in progress.

@LeviHarrison
Copy link
Member

Yeah, benchmarks looked good to me when I checked yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeviHarrison LeviHarrison LeviHarrison left review comments

@roidelapluie roidelapluie roidelapluie approved these changes

@Nexucis Nexucis Nexucis approved these changes

@juliusv juliusv Awaiting requested review from juliusv

Assignees
No one assigned
Labels
prombench
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@beorn7 @LeviHarrison @prombot @roidelapluie @Nexucis