Handle more arithmetic operators for native histograms #12262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenador
force-pushed
the
histogram-promql-operators
branch
2 times, most recently
from
390be44
to
e9e2fa2
Compare
krajorama
reviewed
Apr 24, 2023
zenador
force-pushed
the
histogram-promql-operators
branch
3 times, most recently
from
41272a6
to
b06909c
Compare
zenador
force-pushed
the
histogram-promql-operators
branch
2 times, most recently
from
bc40d62
to
97ac586
Compare
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
zenador
force-pushed
the
histogram-promql-operators
branch
from
97ac586
to
47404c4
Compare
…oats Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
beorn7
requested changes
May 11, 2023
There was a problem hiding this comment.
Looks great. Just some not-so-substantial comments.
Special thanks for the testing. This should be much easier once #11170 is done.
Two other things to do:
- Amend the documentation to explain what works now.
- I think we can/should also fix other aggregation operators (stddev etc.). Some of them can be made work with histograms, others should ignore them cleanly (currently, we count them, which might throw some results off).
I think (1) needs to be included in this PR, but (2) can be done in a separate PR.
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
zenador
force-pushed
the
histogram-promql-operators
branch
from
b6d895d
to
e5ebdb8
Compare
|
Besides what you mentioned, noticed a few more issues:
Updated std var/dev to ignore histograms for now so it won't throw the results off for floats. |
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
zenador
force-pushed
the
histogram-promql-operators
branch
from
e5ebdb8
to
31353ed
Compare
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
|
Good catch with the I'll get to the other points ASAP. |
Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
zenador
force-pushed
the
histogram-promql-operators
branch
from
87ac94a
to
012b2e7
Compare
beorn7
approved these changes
May 16, 2023
Comment on lines
+336
to
+340
| All other operators (and unmentioned cases for the above operators) do not | ||
| behave in a meaningful way. They either treat the histogram sample as if it | ||
| were a float sample of value 0, or (in case of arithmetic operations between a | ||
| scalar and a vector) they leave the histogram sample unchanged. This behavior | ||
| will change to a meaningful one before native histograms are a stable feature. |
There was a problem hiding this comment.
I think this isn't quite true anymore (due to my earlier giant PR). The intention is that native histograms are just ignored, but it needs some research to verify if that's actually the case. Mostly saying this as a mental note to myself. We don't need to fix this paragraph in this PR.
This was referenced May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #12250
Works in unit tests and when manually testing on the UI with scalars and float metrics. This fixes the issue we observed with query sharding histograms with instant query splitting, however the float imprecision accumulates and the final result is very different in unit tests (tolerance was originally 1e-12 for floats but the histogram ones only passed with 1e-2).
Also added avg for native histograms as in #11973, to be discussed there.