Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle more arithmetic operators for native histograms #12262

Merged
merged 14 commits into from
May 16, 2023
Merged

Handle more arithmetic operators for native histograms #12262

merged 14 commits into from
May 16, 2023

Commits on May 5, 2023

  1. Handle more arithmetic operators for native histograms 

    Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
    @zenador
    zenador committed May 5, 2023
    Configuration menu
    Copy the full SHA
    61fa548 View commit details
    Browse the repository at this point in the history

  2. Don't exclude division by 0 

    Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
    @zenador
    zenador committed May 5, 2023
    Configuration menu
    Copy the full SHA
    662d111 View commit details
    Browse the repository at this point in the history

  3. Allow avg operator (simple mean) for native histograms 

    Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
    @zenador
    zenador committed May 5, 2023
    Configuration menu
    Copy the full SHA
    f076636 View commit details
    Browse the repository at this point in the history

  4. Use moving mean when averaging native histograms 

    Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
    @zenador
    zenador committed May 5, 2023
    Configuration menu
    Copy the full SHA
    47404c4 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. Stop calculating sum earlier when native histograms are mixed with fl… 

    …oats

Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
    @zenador
    zenador committed May 9, 2023
    Configuration menu
    Copy the full SHA
    6bdb998 View commit details
    Browse the repository at this point in the history

  2. Add sum/avg_over_time for native histograms 

    Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
    @zenador
    zenador committed May 9, 2023
    Configuration menu
    Copy the full SHA
    14921c1 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. Get rid of duplicated function (Scale == Mul) 

    Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
    @zenador
    zenador committed May 11, 2023
    Configuration menu
    Copy the full SHA
    f32c311 View commit details
    Browse the repository at this point in the history

  2. Add tests for multiplying/dividing by 0 

    Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
    @zenador
    zenador committed May 11, 2023
    Configuration menu
    Copy the full SHA
    3416679 View commit details
    Browse the repository at this point in the history

  3. Revise according to code review 

    Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
    @zenador
    zenador committed May 11, 2023
    Configuration menu
    Copy the full SHA
    c929721 View commit details
    Browse the repository at this point in the history

  4. Rename according to code review 

    Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
    @zenador
    zenador committed May 11, 2023
    Configuration menu
    Copy the full SHA
    e7006c1 View commit details
    Browse the repository at this point in the history

  5. Update docs 

    Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
    @zenador
    zenador committed May 11, 2023
    Configuration menu
    Copy the full SHA
    021a859 View commit details
    Browse the repository at this point in the history

  6. Call compact for operators that don't compact native histograms 

    Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
    @zenador
    zenador committed May 11, 2023
    Configuration menu
    Copy the full SHA
    31353ed View commit details
    Browse the repository at this point in the history

  7. Ignore native histograms when aggregating with std var/dev 

    Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
    @zenador
    zenador committed May 11, 2023
    Configuration menu
    Copy the full SHA
    0fcf0a7 View commit details
    Browse the repository at this point in the history

  8. Rename Scale to Mul 

    Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>
    @zenador
    zenador committed May 11, 2023
    Configuration menu
    Copy the full SHA
    012b2e7 View commit details
    Browse the repository at this point in the history