PoC/draft: make build reproducible #12515
Conversation
While working on reproducible builds for openSUSE, I found that our golang-github-prometheus-prometheus package varied between builds because our Open Build Service randomly selects worker nodes from its pool and prometheus embeds the buildhost name in its binaries. I'd like to avoid to carry this patch downstream, but don't know enough about the build system to override BuildUser from the outside. Signed-off-by: Bernhard M. Wiedemann <bwiedemann@suse.de>
|
We have discussed this pull request during our weekly bug scrub. Thank you for your pull request, this usename/host information is actually useful for us when we get the output of Since you are building using RPM's, did you consider applying this as a patch downstream ? Thanks |
|
Yes. As I wrote above: "I'd like to avoid to carry this patch downstream" Is there a way to have the user+host included by default but be able to override/drop by us, e.g. by setting the |
|
I think, https://github.com/prometheus/promu/blob/master/cmd/build.go#L195 provides a good template there. |
|
Yes, you can send a patch to Promu |
|
This is now moved to prometheus/promu#267 |
While working on reproducible builds for openSUSE, I found that our
golang-github-prometheus-prometheuspackage varied between builds because our Open Build Service randomly selects worker nodes from its pool and prometheus embeds the buildhost name in its binaries.I'd like to avoid to carry this patch downstream,
but don't know enough about the build system to override BuildUser from the outside.