Do not discover user/host for reproducible builds #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to overwrite build user if SOURCE_DATE_EPOCH is set in order to make builds reproducible. See https://reproducible-builds.org/ for why this is good and https://reproducible-builds.org/specs/source-date-epoch/ for the definition of this variable. This PR was done while working on [reproducible builds for openSUSE](https://en.opensuse.org/openSUSE:Reproducible_Builds). Signed-off-by: Witek Bedyk <witold.bedyk@suse.com>
|
Can we abstract The function should have a comment that says that when we think we are in a reproducible scenario, we try to do our best, but there is no guarantee that promu generates reproducible builds on its own. |
Signed-off-by: Witek Bedyk <witold.bedyk@suse.com>
witekest
force-pushed
the
reproducible_builds
branch
from
c9958f6
to
d5f240e
Compare
roidelapluie
approved these changes
Aug 4, 2023
Merged
danielmellado
pushed a commit
to danielmellado/prometheus-promu
that referenced
this pull request
Apr 24, 2024
* [FEATURE] Do not discover user/host for reproducible builds prometheus#267 * [BUGFIX] Fix example/prometheus build error prometheus#274 Signed-off-by: SuperQ <superq@gmail.com>
danielmellado
pushed a commit
to danielmellado/prometheus-promu
that referenced
this pull request
Apr 24, 2024
* [FEATURE] Do not discover user/host for reproducible builds prometheus#267 * [BUGFIX] Fix example/prometheus build error prometheus#274 Signed-off-by: SuperQ <superq@gmail.com> Signed-off-by: Daniel Mellado <dmellado@redhat.com>
danielmellado
pushed a commit
to danielmellado/prometheus-promu
that referenced
this pull request
Apr 24, 2024
* [FEATURE] Do not discover user/host for reproducible builds prometheus#267 * [BUGFIX] Fix example/prometheus build error prometheus#274 Signed-off-by: SuperQ <superq@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to overwrite build user if SOURCE_DATE_EPOCH is set in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good and https://reproducible-builds.org/specs/source-date-epoch/ for the definition of this variable.
This PR was done while working on reproducible builds for openSUSE.