Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document feature flag 'created-timestamp-zero-ingestion' #13279

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

ArthurSens
Copy link
Member

Documenting the feature flag added in #12733

Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Some suggestions 💪🏽

docs/feature_flags.md Outdated Show resolved Hide resolved
docs/feature_flags.md Outdated Show resolved Hide resolved
docs/feature_flags.md Outdated Show resolved Hide resolved
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, last nit! Thanks.


`--enable-feature=created-timestamp-zero-ingestion`

Enables ingestion of created timestamps as a injection of samples with 0 value for created timestamp (when appropriate). See PromCon talk <https://youtu.be/nWf0BfQ5EEA?feature=shared> for details on the created timestamp.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Enables ingestion of created timestamps as a injection of samples with 0 value for created timestamp (when appropriate). See PromCon talk <https://youtu.be/nWf0BfQ5EEA?feature=shared> for details on the created timestamp.
Enables ingestion of created timestamp. Created timestamps are injected as 0 valued samples when appropriate. See [PromCon talk](https://youtu.be/nWf0BfQ5EEA) for details.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't treat my suggestions literally @ArthurSens (: <Link> was just semantically what would be nice, not literal structure of link in markdown (:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, for some reason I thought you were saying that this is how links are shown in the website 😅

Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
@bwplotka bwplotka merged commit 69abd6d into prometheus:main Dec 13, 2023
24 checks passed
@ArthurSens ArthurSens deleted the docs-ct branch December 13, 2023 16:05
fbegyn pushed a commit to fbegyn/prometheus that referenced this pull request Jul 11, 2024
…13279)

Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants