Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scrape: Expose disabling staleness markers #14046

Closed
wants to merge 37 commits into from
Closed

scrape: Expose disabling staleness markers #14046

wants to merge 37 commits into from

Conversation

thampiotr
Copy link 

Please give your PR a title in the form "area: short description".  For example "tsdb: reduce disk usage by 95%"

If your PR is to fix an issue, put "Fixes #issue-number" in the description.

Don't forget!

- Please sign CNCF's Developer Certificate of Origin and sign-off your commits by adding the -s / --signoff flag to `git commit`. See https://github.com/apps/dco for more information.

- If the PR adds or changes a behaviour or fixes a bug of an exported API it would need a unit/e2e test.

- Where possible use only exported APIs for tests to simplify the review and make it as close as possible to an actual library usage.

- Performance improvements would need a benchmark test to prove it.

- All exposed objects should have a comment.

- All comments should start with a capital letter and end with a full stop.

krajorama and others added 30 commits November 28, 2023 13:00
@krajorama
Native histograms vs labels (prometheus#13005)
403551a 
* Document le and quantile label transition due to native histograms

Fixes: prometheus#12984

For full explanation see the related issue. The le and quantile labels
are formatted as float with trailing .0 for whole number values when
native histograms is enabled, e.g. 10.0. This changes the resulting series
in Prometheus if previously we scraped the whole number itself, e.g. 10
over the text format.

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>

---------

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: George Krajcsovits <krajorama@users.noreply.github.com>
@krajorama
Update call to newScrapePool
bbe0615 
Used to have a different signature.

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
@beorn7
Merge pull request prometheus#13202 from krajorama/backport-13005-to-…
0bd4e73 
…2.28

[2.48] Backport: Native histograms vs labels (prometheus#13005)
@jlevesy @cstyan
feat(tsdb/agent): notify remote storage when commit happens (promethe…
74f6aee 
…us#13223)

Signed-off-by: Julien Levesy <jlevesy@gmail.com>
Signed-off-by: Callum Styan <callumstyan@gmail.com>
Co-authored-by: Callum Styan <callumstyan@gmail.com>
@jlevesy @cstyan
fix(wlog/watcher): read segment synchronously when not tailing (prome…
0758ff1 
…theus#13224)

Signed-off-by: Julien Levesy <jlevesy@gmail.com>
Signed-off-by: Callum Styan <callumstyan@gmail.com>
Co-authored-by: Callum Styan <callumstyan@gmail.com>
@bwplotka
Merge pull request prometheus#13251 from prometheus/backport-agent-no…
6034dcb 
…tify-fixes

Backport agent notify fixes
@bwplotka
Cut 2.48.1 + bump in UI pkgs. (prometheus#13258)
3ea56a1 
Signed-off-by: bwplotka <bwplotka@gmail.com>
@LeviHarrison
Fix pr numbers (prometheus#13264)
6389421 
Signed-off-by: Levi Harrison <git@leviharrison.dev>
@marctc @tpaschalis
Drop old inmemory samples
16f53ac 
Co-authored-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
Signed-off-by: Marc Tuduri <marctc@protonmail.com>
@tpaschalis
Avoid copying timeseries when the feature is disabled
54cfa70 
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
Signed-off-by: Marc Tuduri <marctc@protonmail.com>
@tpaschalis
Run gofmt
0887257 
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
Signed-off-by: Marc Tuduri <marctc@protonmail.com>
@marctc @tpaschalis
Clarify docs
722cad6 
Signed-off-by: Marc Tuduri <marctc@protonmail.com>
@marctc @tpaschalis
Add more logging info
07ebf0e 
Signed-off-by: Marc Tuduri <marctc@protonmail.com>
@marctc @tpaschalis
Remove loggers
2c17b2e 
Signed-off-by: Marc Tuduri <marctc@protonmail.com>
@marctc @tpaschalis
optimize function and add tests
345d707 
Signed-off-by: Marc Tuduri <marctc@protonmail.com>
@marctc @tpaschalis
Simplify filter
3430cc3 
Signed-off-by: Marc Tuduri <marctc@protonmail.com>
@marctc @tpaschalis
rename var
993d29e 
Signed-off-by: Marc Tuduri <marctc@protonmail.com>
@marctc @tpaschalis
Update help info from metrics
58e6585 
Signed-off-by: Marc Tuduri <marctc@protonmail.com>
@marctc @tpaschalis
use metrics to keep track of drop elements during buildWriteRequest
2843a2d 
Signed-off-by: Marc Tuduri <marctc@protonmail.com>
@marctc @tpaschalis
rename var in tests
4da6945 
Signed-off-by: Marc Tuduri <marctc@protonmail.com>
@marctc @tpaschalis
pass time.Now as parameter
05b12c2 
Signed-off-by: Marc Tuduri <marctc@protonmail.com>
@marctc @tpaschalis
Change buildwriterequest during retries
4e463e0 
Signed-off-by: Marc Tuduri <marctc@protonmail.com>
@marctc @tpaschalis
Revert "Remove loggers"
3c55462 
This reverts commit 54f91df.

Signed-off-by: Marc Tuduri <marctc@protonmail.com>
@marctc @tpaschalis
use log level debug for loggers
97d8e1d 
Signed-off-by: Marc Tuduri <marctc@protonmail.com>
@tpaschalis
Fix linter
01adc9f 
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
@tpaschalis
Remove noisy debug-level logs; add 'reason' label to drop metrics
69b76ec 
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
@tpaschalis
Remove accidentally committed files
1036cea 
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
@tpaschalis
Propagate logger to buildWriteRequest to log dropped data
d0c5b72 
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
@tpaschalis
Fix docs comment
0328625 
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
@tpaschalis
Make drop reason more specific
4e01348 
Signed-off-by: Paschalis Tsilias <paschalis.tsilias@grafana.com>
@thampiotr thampiotr marked this pull request as draft May 3, 2024 11:27
@thampiotr thampiotr closed this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesusvazquez jesusvazquez Awaiting requested review from jesusvazquez jesusvazquez is a code owner

@cstyan cstyan Awaiting requested review from cstyan cstyan is a code owner

@bwplotka bwplotka Awaiting requested review from bwplotka bwplotka is a code owner

@tomwilkie tomwilkie Awaiting requested review from tomwilkie tomwilkie is a code owner

@juliusv juliusv Awaiting requested review from juliusv juliusv is a code owner

@Nexucis Nexucis Awaiting requested review from Nexucis Nexucis is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@thampiotr @krajorama @beorn7 @jlevesy @bwplotka @LeviHarrison @marctc @tpaschalis @captncraig