Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Allow configuration of a rule evaluation delay #14061

Merged
merged 19 commits into from
May 30, 2024
Merged

Feature: Allow configuration of a rule evaluation delay #14061

merged 19 commits into from
May 30, 2024

Commits on May 16, 2024

  1. [PATCH] Allow having evaluation delay for rule groups 

    Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
    @codesome @gotjosh
    codesome authored and gotjosh committed May 16, 2024
    Configuration menu
    Copy the full SHA
    7e9a108 View commit details
    Browse the repository at this point in the history

  2. [PATCH] Fix lint 

    Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
    @codesome @gotjosh
    codesome authored and gotjosh committed May 16, 2024
    Configuration menu
    Copy the full SHA
    2151a68 View commit details
    Browse the repository at this point in the history

  3. [PATCH] Move the option to ManagerOptions 

    Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
    @codesome @gotjosh
    codesome authored and gotjosh committed May 16, 2024
    Configuration menu
    Copy the full SHA
    64ac4ad View commit details
    Browse the repository at this point in the history

  4. [PATCH] Include evaluation_delay in the group config 

    Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
    @codesome @gotjosh
    codesome authored and gotjosh committed May 16, 2024
    Configuration menu
    Copy the full SHA
    3781b1b View commit details
    Browse the repository at this point in the history

  5. Fix comments 

    Signed-off-by: gotjosh <josue.abreu@gmail.com>
    @gotjosh
    gotjosh committed May 16, 2024
    Configuration menu
    Copy the full SHA
    ef54d80 View commit details
    Browse the repository at this point in the history

  6. Add a server configuration option. 

    Signed-off-by: gotjosh <josue.abreu@gmail.com>
    @gotjosh
    gotjosh committed May 16, 2024
    Configuration menu
    Copy the full SHA
    6402e02 View commit details
    Browse the repository at this point in the history

  7. Appease the linter #1 

    Signed-off-by: gotjosh <josue.abreu@gmail.com>
    @gotjosh
    gotjosh committed May 16, 2024
    Configuration menu
    Copy the full SHA
    c8233f8 View commit details
    Browse the repository at this point in the history

  8. Add the new server flag documentation 

    Signed-off-by: gotjosh <josue.abreu@gmail.com>
    @gotjosh
    gotjosh committed May 16, 2024
    Configuration menu
    Copy the full SHA
    59dbf93 View commit details
    Browse the repository at this point in the history

  9. Improve documentation of the new flag and configuration 

    Signed-off-by: gotjosh <josue.abreu@gmail.com>
    @gotjosh
    gotjosh committed May 16, 2024
    Configuration menu
    Copy the full SHA
    6cf8094 View commit details
    Browse the repository at this point in the history

  10. Use named parameters for clarity on the Rule interface 

    Signed-off-by: gotjosh <josue.abreu@gmail.com>
    @gotjosh
    gotjosh committed May 16, 2024
    Configuration menu
    Copy the full SHA
    22c0812 View commit details
    Browse the repository at this point in the history

  11. Add initial to the flag help 

    Signed-off-by: gotjosh <josue.abreu@gmail.com>
    @gotjosh
    gotjosh committed May 16, 2024
    Configuration menu
    Copy the full SHA
    b747eeb View commit details
    Browse the repository at this point in the history

  12. Change the CHANGELOG area from ruler to rules 

    Signed-off-by: gotjosh <josue.abreu@gmail.com>
    @gotjosh
    gotjosh committed May 16, 2024
    Configuration menu
    Copy the full SHA
    11887ac View commit details
    Browse the repository at this point in the history

  13. Rename evaluation_delay to rule_query_offset/query_offset and mak… 

    …e it a global configuration option.

Signed-off-by: gotjosh <josue.abreu@gmail.com>

E Your branch is up to date with 'origin/gotjosh/evaluation-delay'.
    @gotjosh
    gotjosh committed May 16, 2024
    Configuration menu
    Copy the full SHA
    d8eea8c View commit details
    Browse the repository at this point in the history

  14. more docs 

    Signed-off-by: gotjosh <josue.abreu@gmail.com>
    @gotjosh
    gotjosh committed May 16, 2024
    Configuration menu
    Copy the full SHA
    2982c1f View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Improve wording on CHANGELOG 

    Signed-off-by: gotjosh <josue.abreu@gmail.com>
    @gotjosh
    gotjosh committed May 20, 2024
    Configuration menu
    Copy the full SHA
    8fb75cc View commit details
    Browse the repository at this point in the history

  2. Add RuleQueryOffset to the default config in tests in case it changes 

    Signed-off-by: gotjosh <josue.abreu@gmail.com>
    @gotjosh
    gotjosh committed May 20, 2024
    Configuration menu
    Copy the full SHA
    17cce29 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Update docs/configuration/recording_rules.md 

    Co-authored-by: Julius Volz <julius.volz@gmail.com>
Signed-off-by: gotjosh <josue.abreu@gmail.com>
    @gotjosh @juliusv
    gotjosh and juliusv committed May 29, 2024
    Configuration menu
    Copy the full SHA
    975e040 View commit details
    Browse the repository at this point in the history

  2. Rename RuleQueryOffset to QueryOffset when in the group context. 

    Signed-off-by: gotjosh <josue.abreu@gmail.com>
    @gotjosh
    gotjosh committed May 29, 2024
    Configuration menu
    Copy the full SHA
    ec0cefb View commit details
    Browse the repository at this point in the history

  3. Improve docstring and documentation on the rule_query_offset 

    Signed-off-by: gotjosh <josue.abreu@gmail.com>
    @gotjosh
    gotjosh committed May 29, 2024
    Configuration menu
    Copy the full SHA
    c869b67 View commit details
    Browse the repository at this point in the history