trigger fsnotify by a meaningful write to the config file #3492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krasi-georgiev
force-pushed
the
file-sd-flaky-test
branch
15 times, most recently
from
35fd51c
to
63088ad
Compare
krasi-georgiev
changed the title
gouthamve
reviewed
Nov 20, 2017
discovery/file/file_test.go
Outdated
| retry: | ||
| for { | ||
| select { | ||
| case <-timeout: | ||
| if expect { | ||
| t.Fatalf("Expected new target group but got none") | ||
| } else { | ||
| // invalid type fsd should always broken down. | ||
| // Invalid type fsd should always broken down. |
There was a problem hiding this comment.
The grammar is off here :) Invalid type fsd should always break down.
| close(fileReady) | ||
| <-drainReady | ||
| newf.Close() | ||
| newf.WriteString(" ") // One last meaningless write to trigger fsnotify and a new loop of the discovery service. |
There was a problem hiding this comment.
newf.Sync() would do the trick no? And why doesn't Close() work here, it also syncs the data to disk, AFAIK.
There was a problem hiding this comment.
I tried newf.Sync() and it doesn't trigger a new fsnotify signal
|
Sorry. Reading it again, the initial writes are drained out and we need to trigger a new FSD loop for the changes to be picked up. 👍 for the PR. |
krasi-georgiev
force-pushed
the
file-sd-flaky-test
branch
from
63088ad
to
c4471f4
Compare
krasi-georgiev
force-pushed
the
file-sd-flaky-test
branch
from
c4471f4
to
178e50a
Compare
6 tasks
|
@grobie PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3462