Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the 2.13 release branch #6169

Merged
merged 7 commits into from
Oct 17, 2019

Conversation

krasi-georgiev
Copy link
Contributor

No description provided.

SuperQ and others added 6 commits October 4, 2019 11:44
Add the tsdb tool to promu so that it's included in the release
tarballs.

Signed-off-by: Ben Kochie <superq@gmail.com>
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Signed-off-by: Krasi Georgiev <8903888+krasi-georgiev@users.noreply.github.com>
An extra sync.Pool was added during a refactor which caused some 64 bit,
atomically accessed variables to no longer be 64 bit aligned. By moving
all atomically accessed variables to the beginning of the struct they
are guaranteed to be 64 bit aligned.

Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
* cut 2.13.1 release (prometheus#6099)

Signed-off-by: Krasi Georgiev <8903888+krasi-georgiev@users.noreply.github.com>
@beorn7
Copy link
Member

beorn7 commented Oct 17, 2019

Hmm, I would just merge the prometheus:release-2.13 branch into prometheus:master. But here you are merging one of your own branches.

@beorn7
Copy link
Member

beorn7 commented Oct 17, 2019

I see, there are merge conflicts...

@krasi-georgiev
Copy link
Contributor Author

krasi-georgiev commented Oct 17, 2019

I tried in #6167 , but there is was a merge conflict so needed to create another branch to resolve the conflict

@beorn7
Copy link
Member

beorn7 commented Oct 17, 2019

But why are there so many more commits in here?

Let me try something...

@krasi-georgiev
Copy link
Contributor Author

krasi-georgiev commented Oct 17, 2019

fixed it

I merged my local release branch and not origin/relase....

@beorn7
Copy link
Member

beorn7 commented Oct 17, 2019

I see. Now your attempt and mine (#6171) look the same. 👍 here and I'll remove my own PR.

… into release-merge

Signed-off-by: Krasi Georgiev <8903888+krasi-georgiev@users.noreply.github.com>
Copy link
Member

@beorn7 beorn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge on green.

@krasi-georgiev krasi-georgiev merged commit 5b8ff9b into prometheus:master Oct 17, 2019
@krasi-georgiev krasi-georgiev deleted the release-merge branch October 17, 2019 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants