CircleCI: Fix nodejs cache poisoning #7726
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This wrong cache makes react tests fail Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
juliusv
reviewed
Aug 2, 2020
| @@ -28,7 +28,6 @@ jobs: | |||
| - restore_cache: | |||
| keys: | |||
| - v1-npm-deps-{{ checksum "web/ui/react-app/yarn.lock" }} | |||
| - v1-npm-deps- | |||
There was a problem hiding this comment.
Interesting, in #6181 (comment) @simonpasquier explicitly confirmed this line should be there, but I guess this can cause problems when we actually depend on slightly different packages.
There was a problem hiding this comment.
What I see is tests fail:
o cache is found for key: v1-npm-deps-4FzFT0c3EEonV6JVriNMN0rzzFiM6RAWpqgTIHHJews=
Found a cache from build 36397 at v1-npm-deps-
Size: 56 MiB
Cached paths:
* /home/circleci/project/web/ui/react-app/node_modules
Downloading cache archive...
Validating cache...
Unarchiving cache...
But 36397 is my update deps PR.
I don't know why the cache was not found (https://app.circleci.com/pipelines/github/prometheus/prometheus/8367/workflows/873e94be-223e-4fae-9daf-9f20348d10f1/jobs/36573) but I think we would better start fresh anyway.
There was a problem hiding this comment.
Especially since yarn does not seem to see that the dependencies are wrong.
|
👍 I think, would be good to get confirmation by @simonpasquier |
|
#7727 might be a better fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wrong cache makes tests fail
Signed-off-by: Julien Pivotto roidelapluie@inuits.eu