Add tsdb startup duration metric #7737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should'nt we leverage the timings used in the log messages we already have? |
Signed-off-by: Max Neverov <neverov.max@gmail.com>
mneverov
force-pushed
the
tsdb_startup_metric
branch
from
45ac7f7
to
597f67f
Compare
Fixed |
codesome
reviewed
Aug 25, 2020
codesome
reviewed
Aug 26, 2020
tsdb/head.go
Outdated
| @@ -169,6 +170,10 @@ func newHeadMetrics(h *Head, r prometheus.Registerer) *headMetrics { | |||
| Name: "prometheus_tsdb_wal_corruptions_total", | |||
| Help: "Total number of WAL corruptions.", | |||
| }), | |||
| walTotalReplayDuration: prometheus.NewGauge(prometheus.GaugeOpts{ | |||
| Name: "prometheus_tsdb_wal_total_replay_duration_seconds", | |||
| Help: "Duration of WAL to replay.", | |||
There was a problem hiding this comment.
Suggested change
| Help: "Duration of WAL to replay.", | |
| Help: "Time taken to replay the data on disk.", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7703
I created a new metric
prometheus_tsdb_startup_duration_seconds.Other possible solution may be exposing the total_replay_duration as metric, since the time is spent mostly on WAL load.
Signed-off-by: Maxim Neverov neverov.max@gmail.com
@bwplotka please take a look