[UI] Fix duplicated keys on /targets page #8456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've noticed that I'm getting warnings about multiple children with the same key on /targets page. This adds a test that fails when that happens. Signed-off-by: Łukasz Mierzwa <l.mierzwa@gmail.com>
Since any URI we render on /targets page can have multi-value params we should use both name and value as components keys. Signed-off-by: Łukasz Mierzwa <l.mierzwa@gmail.com>
juliusv
reviewed
Feb 8, 2021
| @@ -27,7 +27,7 @@ const EndpointLink: FC<EndpointLinkProps> = ({ endpoint, globalUrl }) => { | |||
| {params.length > 0 ? <br /> : null} | |||
| {params.map(([labelName, labelValue]: [string, string]) => { | |||
| return ( | |||
| <Badge color="primary" className={`mr-1 ${labelName}`} key={labelName}> | |||
| <Badge color="primary" className={`mr-1 ${labelName}`} key={`${labelName}/${labelValue}`}> | |||
There was a problem hiding this comment.
Oh I just noticed that we have a similar bug here (unrelated to your fix) as I fixed elsewhere in https://github.com/prometheus/prometheus/pull/7902/files, where the label name is put into a class name. Will send a fix for that as well.
|
👍 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.