Add environment variable expansion in external label values #8649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roidelapluie
force-pushed
the
expand-external-labels
branch
2 times, most recently
from
f45c0af
to
b2a2277
Compare
beorn7
approved these changes
Mar 25, 2021
config/config_test.go
Outdated
| c, err := LoadFile("testdata/external_labels.good.yml", false, log.NewNopLogger()) | ||
| require.NoError(t, err) | ||
| require.Equal(t, labels.Label{Name: "bar", Value: "foo"}, c.GlobalConfig.ExternalLabels[0]) | ||
| require.Equal(t, labels.Label{Name: "foo", Value: "${TEST}"}, c.GlobalConfig.ExternalLabels[1]) |
There was a problem hiding this comment.
Perhaps also add one with non-variable text, e.g. "foo${TEST}bar"
|
Note: This is pending a vote: https://groups.google.com/u/3/g/prometheus-developers/c/4JmD_glv0zg |
roidelapluie
force-pushed
the
expand-external-labels
branch
from
b2a2277
to
5f7e441
Compare
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
roidelapluie
force-pushed
the
expand-external-labels
branch
from
5f7e441
to
e635ca8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Julien Pivotto roidelapluie@inuits.eu