-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for recording rule backfiller #8674
Add documentation for recording rule backfiller #8674
Conversation
Signed-off-by: jessicagreben <jessicagrebens@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this!
docs/storage.md
Outdated
|
||
### Usage | ||
|
||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This copy and paste seems fragile, I would remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe say: To see all the options, use promtool tsdb create-blocks-from rules --help
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah i was thinking the same. will change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could setup auto-generated one, but if we do, let's make Pr at some point for all commands (:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bwplotka Is there somewhere we already have the auto-generated one setup? Or would that be something new? If we want to proceed with that, is it worth creating an issue for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! It looks great, but I agree with @roidelapluie suggestions. Let's address them and then LGTM 🚀
docs/storage.md
Outdated
|
||
### Usage | ||
|
||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could setup auto-generated one, but if we do, let's make Pr at some point for all commands (:
Signed-off-by: jessicagreben <jessicagrebens@gmail.com>
Signed-off-by: jessicagreben <jessicagrebens@gmail.com>
Thanks! |
This PR adds documentation for Issue #11 and #8667.