Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #230

Merged
merged 1 commit into from
Dec 7, 2018
Merged

Update dependencies #230

merged 1 commit into from
Dec 7, 2018

Conversation

beorn7
Copy link
Member

@beorn7 beorn7 commented Dec 7, 2018

@simonpasquier my first “real life” usage of Go modules with vendoring. Does this look sane?

Update dependencies
72140e4 
Signed-off-by: beorn7 <beorn@soundcloud.com>
@simonpasquier
Copy link
Member

LGTM.

@beorn7
Copy link
Member Author

beorn7 commented Dec 7, 2018

Thanks.

@beorn7 beorn7 merged commit 9aef9ad into master Dec 7, 2018
@beorn7 beorn7 deleted the beorn7/vendoring branch December 7, 2018 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpasquier simonpasquier Awaiting requested review from simonpasquier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beorn7 @simonpasquier