Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.2.0 #45

Merged
merged 1 commit into from
Jun 24, 2015
Merged

Release 0.2.0 #45

merged 1 commit into from
Jun 24, 2015

Conversation

discordianfish
Copy link
Member

Due to the major change to support arbitrary grouping, this deserves a
MINOR version increment.

Due to the major change to support arbitrary grouping, this deserves a
MINOR version increment.
@brian-brazil
Copy link
Contributor

👍

discordianfish added a commit that referenced this pull request Jun 24, 2015
@discordianfish discordianfish merged commit 8a33cc0 into master Jun 24, 2015
@discordianfish discordianfish deleted the cut-0.2.0-release branch June 24, 2015 23:09
@beorn7
Copy link
Member

beorn7 commented Jun 25, 2015

There is actually a breaking change in the DELETE API call.

The version increment is fine, but the breaking change needs to be documented.

@beorn7
Copy link
Member

beorn7 commented Jun 25, 2015

I have changed the changelog, and will set the tag to after that change.

@beorn7
Copy link
Member

beorn7 commented Jun 25, 2015

@discordianfish I have updated the release tag and info. Could you use your magic script to attach binaries? (Apparently, it doesn't work on Linux...)

@discordianfish
Copy link
Member Author

@beorn7 The magic script isn't working due to #43 :-/
And sorry for not realizing this is a breaking change. Agreed that it should be included in the changelog. Maybe come up with some general guidelines how to manage those things. I think it would make sense for example to update the changelog in the PRs introducing the change. That way it wouldn't be possible to forget mentioning that in a release.

@juliusv
Copy link
Member

juliusv commented Jun 25, 2015

In my experience it's much more reliable to collect changelog entries once when you cut the release than to try and think of updating the changelog with every PR (and also remember to make all external contributors do that). Further, the changelog often doesn't end up with per-PR updates, but a lot of stuff is summarized/squashed together in the end.

@discordianfish
Copy link
Member Author

@juliusv Hrm.. but I think at least for breaking change it would be a good idea.

@grobie
Copy link
Member

grobie commented Jun 25, 2015

My experience is the opposite of @juliusv.

@beorn7
Copy link
Member

beorn7 commented Jun 25, 2015

Ideally, the person who knows the repository in question best should be involved when cutting the release and/or creating the changelog.

@discordianfish
Copy link
Member Author

Whatever we decide, we should document it somewhere. I prefer adding things to the changelog with the PR, it's also useful for people building from master to have a up-to-date changelog. But I leave this to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants