Upgrading client-go and adding ctx parameter to the client go function #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion and few more changes in the k8s provider Signed-off-by: Raj Das <mail.rajdas@gmail.com>
|
Logs- poc-1.log |
|
@rajdas98 Thanks for the PR :) As discussed on riot, need to use the same context. About the tests failing, as the google cloud package was also updated I guess this hit this deprecation issue. @drumilpatel2000 mentioned it few weeks back so he might have more info on this. |
Signed-off-by: Raj Das <mail.rajdas@gmail.com>
imrajdas
changed the title
Signed-off-by: Raj Das <mail.rajdas@gmail.com>
imrajdas
force-pushed
the
poc-2
branch
2 times, most recently
from
b00c62c
to
535ed06
Compare
Signed-off-by: Raj Das <mail.rajdas@gmail.com>
|
@geekodour CI has been fixed PTAL |
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details of the PR is mentioned in the issue #371
Signed-off-by: Raj Das mail.rajdas@gmail.com