Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding --path.rootfs to node exporter arguments and upgrading nodeexporter #408

Merged
merged 6 commits into from
Aug 22, 2020
Merged

Adding --path.rootfs to node exporter arguments and upgrading nodeexporter #408

merged 6 commits into from
Aug 22, 2020

Conversation

imrajdas
Copy link
Contributor

@imrajdas imrajdas commented Jul 8, 2020 •
edited
Loading

Motivation:

  • To show the prometheus metrics of /mnt/disks/ssd0 which is mounted on filesystem /dev/sdb

Changes:

  • Adding --path.rootfs=/host/root to node exporter args
  • Adding volumeMount root which is mount on /host/root
  • Upgrading node exporter to 1.0.1 to support --path.rootfs

Issue: #159 #328
Signed-off-by: Raj Babu Das mail.rajdas@gmail.com

@imrajdas
Adding --path.rootfs to node exporter arguments and upgrade nodeexpor…
800f369 
…ter to 0.18.0

Signed-off-by: Raj Babu Das <mail.rajdas@gmail.com>
@imrajdas
Copy link
Contributor Author

imrajdas commented Jul 8, 2020

cc @geekodour

geekodour
geekodour reviewed Jul 12, 2020
View reviewed changes
Copy link
Member

@geekodour geekodour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! :)

Just some suggestions and changes needed to get the dashboards to show the required info.

prombench/manifests/prombench/benchmark/4_node-exporter.yaml Outdated Show resolved Hide resolved
prombench/manifests/prombench/benchmark/4_node-exporter.yaml Outdated Show resolved Hide resolved
prombench/manifests/prombench/benchmark/4_node-exporter.yaml Show resolved Hide resolved
@imrajdas imrajdas changed the title Adding --path.rootfs to node exporter arguments and upgrading nodeexporter WIP Adding --path.rootfs to node exporter arguments and upgrading nodeexporter Jul 17, 2020
@imrajdas imrajdas mentioned this pull request Aug 4, 2020
Closed
@imrajdas imrajdas changed the title WIP Adding --path.rootfs to node exporter arguments and upgrading nodeexporter Adding --path.rootfs to node exporter arguments and upgrading nodeexporter Aug 14, 2020
@geekodour
Copy link
Member

geekodour commented Aug 15, 2020 •
edited
Loading

Can we add the changes of #424 here aswell? and close #424

@imrajdas
Upgrading version v1.0.1
440550c 
Signed-off-by: Raj Babu Das <mail.rajdas@gmail.com>
@imrajdas
Copy link
Contributor Author

Disk Space Used Basic Dashboard
Selection_008

@imrajdas
Copy link
Contributor Author

File system fullness dashboard
prom-exporter-2

@imrajdas
ignoring tmp disk
5362235 
Signed-off-by: Raj Babu Das <mail.rajdas@gmail.com>
@imrajdas
Merge remote-tracking branch 'upstream/master' into test-ssd
922f294
@imrajdas
ignoring /var disk for prombench node metrics
8cf45b2 
Signed-off-by: Raj Babu Das <mail.rajdas@gmail.com>
@imrajdas
Copy link
Contributor Author

Disk Space Used Basic Dashboard
prombench01-png

File system fullness dashboard
prombench01

@geekodour geekodour merged commit 947efbe into prometheus:master Aug 22, 2020
@geekodour geekodour mentioned this pull request Aug 22, 2020
Closed
@imrajdas imrajdas deleted the test-ssd branch August 22, 2020 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekodour geekodour Awaiting requested review from geekodour

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@imrajdas @geekodour