Adding a infra CLI command to get the prombench service endpoints #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raj Babu Das <raj.das@mayadata.io>
|
cc @geekodour |
imrajdas
changed the title
geekodour
reviewed
Sep 16, 2020
|
|
||
| NodePort = service.Spec.Ports[0].NodePort | ||
|
|
||
| fmt.Printf("Grafana: http://%v:%v/grafana\n", InternalIP, NodePort) |
There was a problem hiding this comment.
Rather than printing the services I think we should just simply print the InternalIP and NodePort and one could use the README to see whatever service the want. :) We primarily want the InternaIP and NodePrort here so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of services endpoints
http://<IP>:<PORT>/grafanahttp://<IP>:<PORT>/prometheus-metahttp://<IP>:<PORT>/grafana/explorefixes: #427