Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag 1.0.0 #56

Closed
briancavalier opened this issue Dec 5, 2012 · 13 comments
Closed

Tag 1.0.0 #56

briancavalier opened this issue Dec 5, 2012 · 13 comments

Comments

@briancavalier
Copy link
Member

Quick straw pull: Are we ready for 1.0.0? 👍 or 👎

If 👎 then please list the specific reasons.

@briancavalier
Copy link
Member Author

👍 The only minor nit I see is 3.2.5.1 and 3.2.5.2 starting with "if". Changing it to "if/when" or "in the fulfilled state" may be better.

@ForbesLindesay
Copy link
Member

👍

@lsmith
Copy link
Contributor

lsmith commented Dec 6, 2012

👍
Agreed with @briancavalier on changing 3.2.5.1 and 3.2.5.2 to "if/when".

One non-content related nit: the gh-pages version of the doc numbers the footnotes as 4.1, 4.2, and 4.3, which doesn't match the links to those footnotes.

@domenic
Copy link
Member

domenic commented Dec 6, 2012

👍 agree on nits.

@briancavalier
Copy link
Member Author

@lsmith great catch! I'll fix these nits shortly.

@briancavalier
Copy link
Member Author

Hmmm, anyone know what's up with 3.1.1?? Why is the sub-bullet not actually a sub-bullet. Looking at the markdown, it's not obvious what is going wrong--maybe a jekyll/gh-pages problem?

@briancavalier
Copy link
Member Author

Nits fixed. If we can figure out the sub-bullet problem, I think we'll be ready.

@lsmith
Copy link
Contributor

lsmith commented Dec 6, 2012

Weird. yeah. Even this comment box supports the formatting as written in the README.md

Requirements

Promise States

A promise must be in one of three states: pending, fulfilled, or rejected.

  1. When in pending, a promise:
    1. may transition to either the fulfilled or rejected state.
  2. When in fulfilled, a promise:
    1. must not transition to any other state.
    2. must have a value, which must not change.
  3. When in rejected, a promise:
    1. must not transition to any other state.
    2. must have a reason, which must not change.

@domenic
Copy link
Member

domenic commented Dec 6, 2012

It'd also be cool to get a domain name.

@briancavalier
Copy link
Member Author

I totally agree about the domain name--that'll be very cool. I think we can go ahead and tag without it, tho.

Anyone know how we might get a domain name for free? Figured I'd at least ask :)

@briancavalier
Copy link
Member Author

Ok, I found a way to work around the apparent jekyll bullet rendering bug in 3.1.1. If there are no other nits by tomorrow afternoon EST, I'll tag.

@briancavalier
Copy link
Member Author

Ok, all, we're 1.0.0 now :) Feel free to tweet it up (although I'll prolly wait for a more optimal tweet time :) )

@unscriptable
Copy link
Member

woohoo! I had a beer in celebration last night.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants