Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gettempdir() for sockets #30

Closed
wants to merge 1 commit into from
Closed

Conversation

eas604
Copy link
Contributor

@eas604 eas604 commented Jan 10, 2016

Change uses tempfile.gettempdir() for working with sockets, rather than hard-coding /tmp. This addresses #12 .

@jonathanslenders
Copy link
Member

Thanks a lot @eas604!
Merged in: 70d9901

(I also wonder whether we can get rid of the bit of code duplication that we have here. That would be a different commit.)

@eas604
Copy link
Contributor Author

eas604 commented Jan 11, 2016

Which code duplication do you mean? The multiple locations where the socket file is defined?

@jonathanslenders
Copy link
Member

Yes, that is a small bit of duplication that I introduced in the beginning. Maybe nothing to worry about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants