New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-evaluated Filter equality lost in 3.0.37 #1729
Comments
Hi, thanks for reporting! It looks like the problem is that the intermediate result of I wonder whether the memory leak that I fixed back then returns if this would be a normal dict. I have to check that. |
Closing as completed. Thanks ! |
I think that 7776bf9 lead to some weird things in filter equality.
Note that this is not when you evaluate the filter, but looking as wether the filter are identical.
We recently in IPython landed a patch from @krassowski that need to do str <-> Filter (for configurability) and compare. That may be the wrong things to do but at least it surfaced this.
I believe there are interning questions due to upstream, and having a custom
__eq__
in _AndList and _OrList seem to fix it, but I wanted to open an issue first.The text was updated successfully, but these errors were encountered: